You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/19 07:51:32 UTC

[GitHub] [incubator-devlake] warren830 opened a new pull request, #2257: refactor(gitlab): add conn id to commit

warren830 opened a new pull request, #2257:
URL: https://github.com/apache/incubator-devlake/pull/2257

   # Summary
   
   1. modify gitlab mr relevant e2e tables
   2. add conn id to gitlab commits and add e2e test
   
   ### Does this close any open issues?
   Please mention the issues here.
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 merged pull request #2257: refactor(gitlab): add conn id to commit-3

Posted by GitBox <gi...@apache.org>.

warren830 merged PR #2257:
URL: https://github.com/apache/incubator-devlake/pull/2257


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #2257: refactor(gitlab): add conn id to commit-3

Posted by GitBox <gi...@apache.org>.

abeizn commented on code in PR #2257:
URL: https://github.com/apache/incubator-devlake/pull/2257#discussion_r901195247


##########
plugins/gitlab/e2e/raw_tables/_raw_gitlab_api_commit.csv:
##########
@@ -0,0 +1,151 @@
+id,params,data,url,input,created_at

Review Comment:
   Too much test case data



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] abeizn commented on pull request #2257: refactor(gitlab): add conn id to commit-3

Posted by GitBox <gi...@apache.org>.

abeizn commented on PR #2257:
URL: https://github.com/apache/incubator-devlake/pull/2257#issuecomment-1159877513

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org