You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/16 11:48:57 UTC

[GitHub] [cloudstack] weizhouapache opened a new pull request #5319: vr: reload dnsmasq when start vms

weizhouapache opened a new pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319


   ### Description
   
   This PR fixed #5208 and #3613
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [x] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-899446984


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-902156716


   <b>Trillian test result (tid-1720)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32843 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5319-t1720-kvm-centos7.zip
   Smoke tests completed. 87 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-901696888


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#discussion_r691825884



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -58,17 +58,11 @@ def process(self):
         if self.conf.commit():
             restart_dnsmasq = True
 
-        if self.cloud.commit():
-            restart_dnsmasq = True
-
-        if self.dhcp_leases.commit():
-            restart_dnsmasq = True
-
+        self.dhcp_hosts.commit()
+        self.dhcp_leases.commit()
         self.dhcp_opts.commit()
 
-        if restart_dnsmasq:
-            self.delete_leases()
-
+        self.delete_leases()
         self.write_hosts()

Review comment:
       @weizhouapache can you explain what this line does? Isn't deleting leases going to cause any regression? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache closed pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-903736569


   > Suggested tests if not already done - please check/confirm @weizhouapache cc @nvazquez
   > 
   > Monitor dnsmasq service and check expected outcome for cases in both isolated network and VPC tier: (maybe more cases you can think of?)
   > 
   > * Deploy two VMs, stop one VM (check dnsmasq status or cloud.log), start the stopped VM, stop the VM and destroy it
   > * Deploy two VMs, destroy one VM, check dnsmasq entries/logs
   > * Deploy two VMs, create a new network; plug secondary nic and perform above (behaviour of dnsmasq when nics of VMs are on secondary networks)
   > * Deploy two VMs on two different VPC tier, stop one VM, destroy another, start another VM in a new tier, start a VM in existing VM
   
   @rhtyd @nvazquez  I will test the scenarios.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-900468265


   <b>Trillian test result (tid-1675)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33326 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5319-t1675-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Smoke tests completed. 87 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-900054130


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-899917998


   <b>Trillian test result (tid-1662)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42699 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5319-t1662-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestRouterRules>:teardown | `Error` | 148.55 | test_network.py
   test_03_deploy_and_scale_kubernetes_cluster | `Error` | 167.71 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 46.10 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#discussion_r691878427



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -58,17 +58,11 @@ def process(self):
         if self.conf.commit():
             restart_dnsmasq = True
 
-        if self.cloud.commit():
-            restart_dnsmasq = True
-
-        if self.dhcp_leases.commit():
-            restart_dnsmasq = True
-
+        self.dhcp_hosts.commit()
+        self.dhcp_leases.commit()
         self.dhcp_opts.commit()
 
-        if restart_dnsmasq:
-            self.delete_leases()
-
+        self.delete_leases()
         self.write_hosts()

Review comment:
       @rhtyd anyway, I added a new commit to address your comment.
   
   leases will be deleted only when one of config files is changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-899447265


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-901747640


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-899469895


   @weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-899469424


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#discussion_r692871608



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -58,17 +58,11 @@ def process(self):
         if self.conf.commit():
             restart_dnsmasq = True
 
-        if self.cloud.commit():
-            restart_dnsmasq = True
-
-        if self.dhcp_leases.commit():
-            restart_dnsmasq = True
-
+        self.dhcp_hosts.commit()
+        self.dhcp_leases.commit()
         self.dhcp_opts.commit()
 
-        if restart_dnsmasq:
-            self.delete_leases()
-
+        self.delete_leases()
         self.write_hosts()

Review comment:
       Great thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-899867717


   <b>Trillian test result (tid-1660)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34271 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5319-t1660-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 87 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-904473913


   > Suggested tests if not already done - please check/confirm @weizhouapache cc @nvazquez
   > 
   > Monitor dnsmasq service and check expected outcome for cases in both isolated network and VPC tier: (maybe more cases you can think of?)
   > 
   > * Deploy two VMs, stop one VM (check dnsmasq status or cloud.log), start the stopped VM, stop the VM and destroy it
   > * Deploy two VMs, destroy one VM, check dnsmasq entries/logs
   > * Deploy two VMs, create a new network; plug secondary nic and perform above (behaviour of dnsmasq when nics of VMs are on secondary networks)
   > * Deploy two VMs on two different VPC tier, stop one VM, destroy another, start another VM in a new tier, start a VM in existing VM
   
   @rhtyd ,cc @nvazquez 
   I have tested all scenarios above, they work fine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache closed pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-901723741


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 931


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-902627375


   Suggested tests if not already done - please check/confirm @weizhouapache cc @nvazquez
   
   Monitor dnsmasq service and check expected outcome for cases in both isolated network and VPC tier: (maybe more cases you can think of?)
   - Deploy two VMs, stop one VM (check dnsmasq status or cloud.log), start the stopped VM, stop the VM and destroy it
   - Deploy two VMs, destroy one VM, check dnsmasq entries/logs
   - Deploy two VMs, create a new network; plug secondary nic and perform above (behaviour of dnsmasq when nics of VMs are on secondary networks)
   - Deploy two VMs on two different VPC tier, stop one VM, destroy another, start another VM in a new tier, start a VM in existing VM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-900053945


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#discussion_r691870276



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -58,17 +58,11 @@ def process(self):
         if self.conf.commit():
             restart_dnsmasq = True
 
-        if self.cloud.commit():
-            restart_dnsmasq = True
-
-        if self.dhcp_leases.commit():
-            restart_dnsmasq = True
-
+        self.dhcp_hosts.commit()
+        self.dhcp_leases.commit()
         self.dhcp_opts.commit()
 
-        if restart_dnsmasq:
-            self.delete_leases()
-
+        self.delete_leases()
         self.write_hosts()

Review comment:
       @rhtyd 
   the method delete_leases was mainly introduced by #3351, which is used to remove entries from dnsmasq.leases file for VMs which have  been removed (no impact on all existing vms).
   
   in my opinion, it will not cause any regression. the only issue I see is that execution time will be increased few milliseconds if stop/start a vm(currently delete_leases is not triggered).
    https://github.com/apache/cloudstack/blob/737f50d133c918f1f61580c1c23ebf37b12a3799/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py#L134-L154




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-901746836


   @blueorangutan test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-899461518


   Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian. SL-JID 883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-900468265


   <b>Trillian test result (tid-1675)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33326 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5319-t1675-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Smoke tests completed. 87 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez merged pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-899964401


   <b>Trillian test result (tid-1661)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 50758 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5319-t1661-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 84 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 313.46 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 311.95 | test_routers_network_ops.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 427.85 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 476.03 | test_vpc_redundant.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1511.55 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5319: vr: reload dnsmasq when start vms

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-901697129


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org