You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/26 03:11:27 UTC
[GitHub] [flink] fsk119 opened a new pull request, #20358: [FLINK-28679][hive] Use fixed version for hive-service-rpc
fsk119 opened a new pull request, #20358:
URL: https://github.com/apache/flink/pull/20358
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Use fixed hive server2 version. Because the different version of hiveserver2 has different interfaces. Currently, the hive connector uses reflection to get the classes in the hive jar with different versions. However, it doesn't work for the hiveserver2 endpoint because the hiveserver2 endpoint needs to implement the interface in the dynamic hive jars. To solve this, we may need to introduce a Proxy to delegate the different requests to a hive-free server.
## Verifying this change
I have run `mvn clean install -T 4 -DskipTests -Pskip-webui-build -Phadoop3-tests,hive3` in my local environment. The problem in the issue doesn't appear.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #20358: [FLINK-28679][hive] Use fixed version for hive-service-rpc
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20358:
URL: https://github.com/apache/flink/pull/20358#issuecomment-1195317384
When running personal CI, change https://github.com/apache/flink/blob/master/azure-pipelines.yml#L80 to https://github.com/apache/flink/blob/master/tools/azure-pipelines/build-apache-repo.yml#L127.
For PRs, change https://github.com/apache/flink/blob/master/tools/azure-pipelines/build-apache-repo.yml#L73 to https://github.com/apache/flink/blob/master/tools/azure-pipelines/build-apache-repo.yml#L127.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20358: [FLINK-28679][hive] Use fixed version for hive-service-rpc
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20358:
URL: https://github.com/apache/flink/pull/20358#issuecomment-1195288057
Thanks for pointing it out. But I find I can not run the nightlies script in my azure pipeline. It reports
```
Variables:
SECRET_S3_BUCKET:
Parsing expression: <variables.IT_CASE_S3_BUCKET>
Evaluating: variables['IT_CASE_S3_BUCKET']
Expanded: Null
Result: ''
SECRET_S3_ACCESS_KEY:
Parsing expression: <variables.IT_CASE_S3_ACCESS_KEY>
Evaluating: variables['IT_CASE_S3_ACCESS_KEY']
Expanded: Null
Result: ''
SECRET_S3_SECRET_KEY:
Parsing expression: <variables.IT_CASE_S3_SECRET_KEY>
Evaluating: variables['IT_CASE_S3_SECRET_KEY']
Expanded: Null
Result: ''
SECRET_GLUE_SCHEMA_ACCESS_KEY:
Parsing expression: <variables.IT_CASE_GLUE_SCHEMA_ACCESS_KEY>
Evaluating: variables['IT_CASE_GLUE_SCHEMA_ACCESS_KEY']
Expanded: Null
Result: ''
SECRET_GLUE_SCHEMA_SECRET_KEY:
Parsing expression: <variables.IT_CASE_GLUE_SCHEMA_SECRET_KEY>
Evaluating: variables['IT_CASE_GLUE_SCHEMA_SECRET_KEY']
Expanded: Null
Result: ''
```
Could you give me some hints on how to run the test with the hadoop3 profile in azure?
[1] https://dev.azure.com/1059623455/Flink/_build/results?buildId=313&view=logs&j=b1fcf054-9138-5463-c73c-a49979b9ac2a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20358: [FLINK-28679][hive] Use fixed version for hive-service-rpc
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20358:
URL: https://github.com/apache/flink/pull/20358#issuecomment-1196779920
@zentol The CI test passes with the hive3 profile. Could you spend some time reviewing the PR? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #20358: [FLINK-28679][hive] Use fixed version for hive-service-rpc
Posted by GitBox <gi...@apache.org>.
wuchong merged PR #20358:
URL: https://github.com/apache/flink/pull/20358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20358: [FLINK-28679][hive] Use fixed version for hive-service-rpc
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20358:
URL: https://github.com/apache/flink/pull/20358#issuecomment-1194947295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b9aa1d05ad91f397d02c5952a159d5d967111c66",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b9aa1d05ad91f397d02c5952a159d5d967111c66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b9aa1d05ad91f397d02c5952a159d5d967111c66 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #20358: [FLINK-28679][hive] Use fixed version for hive-service-rpc
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20358:
URL: https://github.com/apache/flink/pull/20358#issuecomment-1195205405
Please link a build with the hadoop3 profile active to verify that this works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20358: [FLINK-28679][hive] Use fixed version for hive-service-rpc
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20358:
URL: https://github.com/apache/flink/pull/20358#issuecomment-1197601996
The misc module passes both in the [hive3](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=38809&view=results) and [hive2](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=38838&view=results) profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org