You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/09/03 15:06:58 UTC
Re: Review Request 37505: Fix broken health check in docker executor.
> On Aug. 31, 2015, 4:32 a.m., Timothy Chen wrote:
> > src/docker/executor.cpp, line 361
> > <https://reviews.apache.org/r/37505/diff/5/?file=1060003#file1060003line361>
> >
> > You should be able to push the arguments with another vector insert?
> >
> > e.g:
> >
> > argv.push_back("--executor");
> > argv.push_back(stringify(self());
> > .....
If I use this way, I got error like this:
```
Failed to load non-boolean flag 'executor': Missing value
Usage: lt-mesos-health-check [options]
--executor=VALUE Executor UPID to send health check messages to
--health_check_json=VALUE JSON describing health check to perform
--[no-]help Prints this help message (default: false)
--task_id=VALUE Task ID that this health check process is checking
```
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review97053
-----------------------------------------------------------
On Aug. 30, 2015, 10:23 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37505/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 10:23 a.m.)
>
>
> Review request for mesos, Adam B and Timothy Chen.
>
>
> Bugs: MESOS-3136
> https://issues.apache.org/jira/browse/MESOS-3136
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix broken health check in docker executor.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b
> src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5
> src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77
> src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad
> src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea
>
> Diff: https://reviews.apache.org/r/37505/diff/
>
>
> Testing
> -------
>
> # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> # Docker health check command is run through "docker exec"
> sudo ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
> sudo ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" --verbose
>
>
> Thanks,
>
> haosdent huang
>
>