[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #704: Ensure that catalog files are added to the native image

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #704: Ensure that catalog files are added to the native image
URL: https://github.com/apache/camel-quarkus/pull/704#discussion_r378130392
 
 

 ##########
 File path: extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelConfig.java
 ##########
 @@ -174,4 +180,48 @@
         public Optional<List<String>> includePatterns;
     }
 
+    @ConfigGroup
+    public static class RuntimeCatalogConfig {
+        /**
+         * Enable {@link CamelRuntimeCatalog} functionaries.
+         */
+        @ConfigItem(defaultValue = "true")
+        public boolean enabled;
+
+        /**
+         * Used to control the resolution of components catalog info.
 
 Review comment:
   > Is "resolution" really what this does? Would not "inclusion" suit better?
   > 
   
   
   It is resolution, if you go through the code you'd see that this flag controls if the runtime catalog should attempt or not to resolve the given name to its model
   
   
   > Again, it may be unclear to the reader, what is catalog. Maybe a link to a Camel docs page explaining the concept would be nice. The description should give me a hint why/when should I care, why would I ever need this to be true?
   > 
   
   The impact on the native image is described a few lines below.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services