[GitHub] [incubator-druid] xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation

[GitBox <gi...@apache.org>]

xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation
URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r287462420
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/java/util/common/DefineClassUtils.java
 ##########
 @@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.java.util.common;
+
+import org.apache.druid.utils.JvmUtils;
+
+import java.lang.invoke.MethodHandle;
+import java.lang.invoke.MethodHandles;
+import java.lang.invoke.MethodType;
+import java.security.ProtectionDomain;
+
+/**
+ * This utility class provides a thin runtime abstraction to pick between
+ * - sun.misc.Unsafe.defineClass in Java 8,
+ * - and MethodHandles.Lookup.defineClass in Java 9 and above,
+ * while still providing compile-time support for both Java 8 and Java 9+.
+ *
+ * See also {@link ByteBufferUtils}
+ */
+public class DefineClassUtils
 
 Review comment:
   Only portions of ByteBufferUtils are adapted from Apache Kafka. I already updated the LICENSE file in this PR https://github.com/apache/incubator-druid/pull/7466/files#diff-9879d6db96fd29134fc802214163b95aR269
   
   I did not see any corresponding NOTICE changes for bits we adapted from other projects, so I followed the same model. cc @julianhyde you might be able to clarify the nuance of NOTICE/LICENSE. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org