[GitHub] [spark] viirya commented on a change in pull request #24464: [SPARK-27439][SQL] Use existing queryexecution in explaining Dataset

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #24464: [SPARK-27439][SQL] Use existing queryexecution in explaining Dataset
URL: https://github.com/apache/spark/pull/24464#discussion_r280041817
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -498,7 +498,8 @@ class Dataset[T] private[sql](
    * @since 1.6.0
    */
   def explain(extended: Boolean): Unit = {
-    val explain = ExplainCommand(queryExecution.logical, extended = extended)
+    val explain = ExplainCommand(queryExecution.logical, extended = extended,
 
 Review comment:
   `ExplainCommand` is also created in `SparkSqlParser` where there is no `QueryExecution`. So it has both `LogicalPlan` and `QueryExecution` parameters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org