You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "alekjarmov (via GitHub)" <gi...@apache.org> on 2025/04/15 13:07:11 UTC
[PR] [SPARK-51803][Core] Store remote JDBC type in the spark schema in the… [spark]
alekjarmov opened a new pull request, #50591:
URL: https://github.com/apache/spark/pull/50591
… metadata of StructField
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Store in the metadata of each StructField in JDBC connections the remote data type.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
it can be useful when looking at analyzed plan to know how remote data types are mapped to spark types.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
By extending existing unit tests to verify the new funcitonality.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store remote JDBC type in the spark schema in the… [spark]
Posted by "alekjarmov (via GitHub)" <gi...@apache.org>.
alekjarmov commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2045209886
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##########
@@ -59,6 +59,15 @@ class MySQLIntegrationSuite extends DockerJDBCIntegrationV2Suite with V2JDBCTest
override val catalogName: String = "mysql"
override val db = new MySQLDatabaseOnDocker
+ override def defaultMetadata(
Review Comment:
Yeah type names should be common there might be some difference in behavior in some specific, but it wouldn't matter for tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store remote JDBC type in the spark schema in the… [spark]
Posted by "alekjarmov (via GitHub)" <gi...@apache.org>.
alekjarmov commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2045212853
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -48,12 +48,26 @@ private[v2] trait V2JDBCTest extends SharedSparkSession with DockerIntegrationFu
def notSupportsTableComment: Boolean = false
- def defaultMetadata(dataType: DataType = StringType): Metadata = new MetadataBuilder()
+ def defaultMetadata(
+ dataType: DataType = StringType,
+ remoteTypeName: String = "STRING"): Metadata = new MetadataBuilder()
.putLong("scale", 0)
.putBoolean("isTimestampNTZ", false)
.putBoolean("isSigned", dataType.isInstanceOf[NumericType])
+ .putString("remoteTypeName", remoteTypeName)
.build()
+ def removeMetadataFromAllFields(structType: StructType, metadataKey: String): StructType = {
Review Comment:
Added doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store external engine JDBC type in the spark schema in the… [spark]
Posted by "alekjarmov (via GitHub)" <gi...@apache.org>.
alekjarmov commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2045209886
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##########
@@ -59,6 +59,15 @@ class MySQLIntegrationSuite extends DockerJDBCIntegrationV2Suite with V2JDBCTest
override val catalogName: String = "mysql"
override val db = new MySQLDatabaseOnDocker
+ override def defaultMetadata(
Review Comment:
`isSigned` is different, always true in MariaDB and true in numeric types for MySQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store remote JDBC type in the spark schema in the… [spark]
Posted by "alekjarmov (via GitHub)" <gi...@apache.org>.
alekjarmov commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2045088510
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -314,6 +314,7 @@ object JdbcUtils extends Logging with SQLConfHelper {
metadata.putBoolean("isSigned", isSigned)
metadata.putBoolean("isTimestampNTZ", isTimestampNTZ)
metadata.putLong("scale", fieldScale)
+ metadata.putString("remoteTypeName", typeName)
Review Comment:
I can do `externalEngineTypeName`, I think it's most accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store remote JDBC type in the spark schema in the… [spark]
Posted by "urosstan-db (via GitHub)" <gi...@apache.org>.
urosstan-db commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2044550940
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -152,7 +178,11 @@ private[v2] trait V2JDBCTest extends SharedSparkSession with DockerIntegrationFu
val t = spark.table(s"$catalogName.alt_table")
val expectedSchema = new StructType()
.add("C2", StringType, true, defaultMetadata())
- assert(t.schema === expectedSchema)
+ val expectedSchemaWithoutRemoteTypeName =
+ removeMetadataFromAllFields(expectedSchema, "remoteTypeName")
+ val schemaWithoutRemoteTypeName =
+ removeMetadataFromAllFields(t.schema, "remoteTypeName")
+ assert(schemaWithoutRemoteTypeName === expectedSchemaWithoutRemoteTypeName)
Review Comment:
I know this is not your change, but it is better to use `assertResult` than `assert` whenever it is possible, since assertResult gives better error message.
Assert failure would return "Schema(...) did not equal Schema(...)"
while
AssertResult failure would return "Expected schemas is Schema(...), while actual one is Schema(...)"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store external engine JDBC type in the spark schema in the… [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2045880283
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -314,6 +314,7 @@ object JdbcUtils extends Logging with SQLConfHelper {
metadata.putBoolean("isSigned", isSigned)
metadata.putBoolean("isTimestampNTZ", isTimestampNTZ)
metadata.putLong("scale", fieldScale)
+ metadata.putString("externalEngineTypeName", typeName)
Review Comment:
There could be a type conversion when a JDBC client gets the ResultSetMetaData from DB systems. It's not always the DB-engine type. Names like `jdbcType`/`jdbcClientType` might be more acurate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store external engine JDBC type in the spark schema in the… [spark]
Posted by "alekjarmov (via GitHub)" <gi...@apache.org>.
alekjarmov commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2045209886
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##########
@@ -59,6 +59,15 @@ class MySQLIntegrationSuite extends DockerJDBCIntegrationV2Suite with V2JDBCTest
override val catalogName: String = "mysql"
override val db = new MySQLDatabaseOnDocker
+ override def defaultMetadata(
Review Comment:
`isSigned` is different, always true in MariaDB and integer type is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store external engine JDBC type in the spark schema in the… [spark]
Posted by "alekjarmov (via GitHub)" <gi...@apache.org>.
alekjarmov commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2048454582
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -314,6 +314,7 @@ object JdbcUtils extends Logging with SQLConfHelper {
metadata.putBoolean("isSigned", isSigned)
metadata.putBoolean("isTimestampNTZ", isTimestampNTZ)
metadata.putLong("scale", fieldScale)
+ metadata.putString("externalEngineTypeName", typeName)
Review Comment:
Changed to jdbcClientType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store external engine JDBC type in the spark schema in the… [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #50591:
URL: https://github.com/apache/spark/pull/50591#issuecomment-2813004458
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store external engine JDBC type in the spark schema in the… [spark]
Posted by "alekjarmov (via GitHub)" <gi...@apache.org>.
alekjarmov commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2045212212
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##########
@@ -282,12 +297,6 @@ class MySQLIntegrationSuite extends DockerJDBCIntegrationV2Suite with V2JDBCTest
*/
@DockerTest
class MySQLOverMariaConnectorIntegrationSuite extends MySQLIntegrationSuite {
- override def defaultMetadata(dataType: DataType = StringType): Metadata = new MetadataBuilder()
Review Comment:
Info: This is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store external engine JDBC type in the spark schema in the… [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2048261494
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -314,6 +314,7 @@ object JdbcUtils extends Logging with SQLConfHelper {
metadata.putBoolean("isSigned", isSigned)
metadata.putBoolean("isTimestampNTZ", isTimestampNTZ)
metadata.putLong("scale", fieldScale)
+ metadata.putString("externalEngineTypeName", typeName)
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store remote JDBC type in the spark schema in the… [spark]
Posted by "urosstan-db (via GitHub)" <gi...@apache.org>.
urosstan-db commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2044543204
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##########
@@ -59,6 +59,15 @@ class MySQLIntegrationSuite extends DockerJDBCIntegrationV2Suite with V2JDBCTest
override val catalogName: String = "mysql"
override val db = new MySQLDatabaseOnDocker
+ override def defaultMetadata(
Review Comment:
This is common for MariaDB and MySQL JDBC driver?
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -48,12 +48,26 @@ private[v2] trait V2JDBCTest extends SharedSparkSession with DockerIntegrationFu
def notSupportsTableComment: Boolean = false
- def defaultMetadata(dataType: DataType = StringType): Metadata = new MetadataBuilder()
+ def defaultMetadata(
+ dataType: DataType = StringType,
+ remoteTypeName: String = "STRING"): Metadata = new MetadataBuilder()
.putLong("scale", 0)
.putBoolean("isTimestampNTZ", false)
.putBoolean("isSigned", dataType.isInstanceOf[NumericType])
+ .putString("remoteTypeName", remoteTypeName)
.build()
+ def removeMetadataFromAllFields(structType: StructType, metadataKey: String): StructType = {
Review Comment:
nit: maybe
```suggestion
def getSchemaWithoutFieldsMetadata(structType: StructType, metadataKey: String): StructType = {
```
or just add doc to describe what function does, I think current name is also ok in that case.
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MsSqlServerIntegrationSuite.scala:
##########
@@ -258,3 +268,8 @@ class MsSqlServerIntegrationSuite extends DockerJDBCIntegrationV2Suite with V2JD
assert(rows(0).getString(0) === "amy")
}
}
+
+object MsSQLRemoteTypes {
Review Comment:
nit: Since we introduce another top level class for this file, I suggest to make this singleton object part of suite class? Or to make constants in suite, since object is used only here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store remote JDBC type in the spark schema in the… [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2044587298
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -314,6 +314,7 @@ object JdbcUtils extends Logging with SQLConfHelper {
metadata.putBoolean("isSigned", isSigned)
metadata.putBoolean("isTimestampNTZ", isTimestampNTZ)
metadata.putLong("scale", fieldScale)
+ metadata.putString("remoteTypeName", typeName)
Review Comment:
how about `originalTypeName`? "remote" is not always accurate as the JDBC data source also supports embedded RDBMS, i.e. H2, Derby.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store external engine JDBC type in the spark schema in the… [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #50591: [SPARK-51803][Core] Store external engine JDBC type in the spark schema in the…
URL: https://github.com/apache/spark/pull/50591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store remote JDBC type in the spark schema in the… [spark]
Posted by "alekjarmov (via GitHub)" <gi...@apache.org>.
alekjarmov commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2045216463
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -152,7 +178,11 @@ private[v2] trait V2JDBCTest extends SharedSparkSession with DockerIntegrationFu
val t = spark.table(s"$catalogName.alt_table")
val expectedSchema = new StructType()
.add("C2", StringType, true, defaultMetadata())
- assert(t.schema === expectedSchema)
+ val expectedSchemaWithoutRemoteTypeName =
+ removeMetadataFromAllFields(expectedSchema, "remoteTypeName")
+ val schemaWithoutRemoteTypeName =
+ removeMetadataFromAllFields(t.schema, "remoteTypeName")
+ assert(schemaWithoutRemoteTypeName === expectedSchemaWithoutRemoteTypeName)
Review Comment:
Didn't update since I couldn't manage to run tests locally (and don't want to fail another pipeline in case it won't work), but we can write down an issue for this test cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51803][Core] Store remote JDBC type in the spark schema in the… [spark]
Posted by "alekjarmov (via GitHub)" <gi...@apache.org>.
alekjarmov commented on code in PR #50591:
URL: https://github.com/apache/spark/pull/50591#discussion_r2045212212
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##########
@@ -282,12 +297,6 @@ class MySQLIntegrationSuite extends DockerJDBCIntegrationV2Suite with V2JDBCTest
*/
@DockerTest
class MySQLOverMariaConnectorIntegrationSuite extends MySQLIntegrationSuite {
- override def defaultMetadata(dataType: DataType = StringType): Metadata = new MetadataBuilder()
Review Comment:
This is not needed.
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##########
@@ -282,12 +297,6 @@ class MySQLIntegrationSuite extends DockerJDBCIntegrationV2Suite with V2JDBCTest
*/
@DockerTest
class MySQLOverMariaConnectorIntegrationSuite extends MySQLIntegrationSuite {
- override def defaultMetadata(dataType: DataType = StringType): Metadata = new MetadataBuilder()
Review Comment:
Info: This is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org