You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/15 07:22:22 UTC
[GitHub] [arrow-rs] aiglematth opened a new pull request #556: Update triplet.rs
aiglematth opened a new pull request #556:
URL: https://github.com/apache/arrow-rs/pull/556
Update triplet.rs to support REPEATED field with null value at one place
# Which issue does this PR close?
No
# Rationale for this change
Used to manage REPEATED fields with null values. Drill generates it for example when creating the parquet.
# What changes are included in this PR?
Replace the assert statement by an if statement that return a `Field::Null` value in the `pub fn current_value(&self) -> Field` locate in record/triplet.rs.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #556: Update triplet.rs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #556:
URL: https://github.com/apache/arrow-rs/pull/556#issuecomment-880468401
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/556?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#556](https://codecov.io/gh/apache/arrow-rs/pull/556?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1725c7) into [master](https://codecov.io/gh/apache/arrow-rs/commit/f873d77bc77847b95921374aa66ba1d38e9cebf8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f873d77) will **decrease** coverage by `0.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
- Coverage 82.47% 82.47% -0.01%
==========================================
Files 167 167
Lines 46144 46145 +1
==========================================
Hits 38059 38059
- Misses 8085 8086 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/record/triplet.rs](https://codecov.io/gh/apache/arrow-rs/pull/556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvcmVjb3JkL3RyaXBsZXQucnM=) | `92.37% <50.00%> (-0.42%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/556?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/556?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f873d77...e1725c7](https://codecov.io/gh/apache/arrow-rs/pull/556?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #556: Update triplet.rs to support REPEATED field with null value at one place
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #556:
URL: https://github.com/apache/arrow-rs/pull/556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #556: Update triplet.rs to support REPEATED field with null value at one place
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #556:
URL: https://github.com/apache/arrow-rs/pull/556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #556: Update triplet.rs to support REPEATED field with null value at one place
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #556:
URL: https://github.com/apache/arrow-rs/pull/556#issuecomment-882800471
Thank you @aiglematth for the contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #556: Update triplet.rs to support REPEATED field with null value at one place
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #556:
URL: https://github.com/apache/arrow-rs/pull/556#issuecomment-882800471
Thank you @aiglematth for the contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #556: Update triplet.rs to support REPEATED field with null value at one place
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #556:
URL: https://github.com/apache/arrow-rs/pull/556#issuecomment-882800471
Thank you @aiglematth for the contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org