[GitHub] [lucene] jbellis commented on pull request #12281: Add checks in KNNVectorField / KNNVectorQuery to only allow non-null, non-empty and finite vectors

["jbellis (via GitHub)" <gi...@apache.org>]

jbellis commented on PR #12281:
URL: https://github.com/apache/lucene/pull/12281#issuecomment-1586192013

   In the original PR I posted an example of a vector composed of finite floats whose cosine with itself was NaN (`TestVectorConstants.largeVector`).  It was longer than 1024 dimension (1536, which is what OpenAI's Ada embeddings return) but I have very low confidence that you can't get similar results with 1024 or 768 (which seems to be the other most common embedding length).  That's why I think it's a good idea to check the result for "sanity".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org