You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sentry.apache.org by ka...@apache.org on 2017/11/09 18:51:56 UTC
sentry git commit: SENTRY-2018: Remove
SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase
classes. (Kalyan Kumar Kalvagadda, reviewed-by: Sergio Pena)
Repository: sentry
Updated Branches:
refs/heads/master fe48f482e -> 8a80d60bb
SENTRY-2018: Remove SentryMetastorePostEventListener and SentryMetastorePostEventListenerBase classes. (Kalyan Kumar Kalvagadda, reviewed-by: Sergio Pena)
Project: http://git-wip-us.apache.org/repos/asf/sentry/repo
Commit: http://git-wip-us.apache.org/repos/asf/sentry/commit/8a80d60b
Tree: http://git-wip-us.apache.org/repos/asf/sentry/tree/8a80d60b
Diff: http://git-wip-us.apache.org/repos/asf/sentry/diff/8a80d60b
Branch: refs/heads/master
Commit: 8a80d60bb61a0d39154ca23776e57640b8573e09
Parents: fe48f48
Author: Kalyan Kumar Kalvagadda <kk...@cloudera.com>
Authored: Thu Nov 9 12:51:24 2017 -0600
Committer: Kalyan Kumar Kalvagadda <kk...@cloudera.com>
Committed: Thu Nov 9 12:51:24 2017 -0600
----------------------------------------------------------------------
.../e2e/hive/AbstractTestWithStaticConfiguration.java | 10 ++--------
.../metastore/TestSentryListenerInBuiltDeserializer.java | 1 -
.../metastore/TestSentryListenerSentryDeserializer.java | 1 -
3 files changed, 2 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/sentry/blob/8a80d60b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
----------------------------------------------------------------------
diff --git a/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
index 630bc68..a6e7356 100644
--- a/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
+++ b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
@@ -52,7 +52,6 @@ import org.apache.hadoop.hive.conf.HiveConf;
import org.apache.hadoop.hive.conf.HiveConf.ConfVars;
import org.apache.sentry.binding.hive.SentryHiveAuthorizationTaskFactoryImpl;
import org.apache.sentry.binding.metastore.SentryMetastorePostEventListenerNotificationLog;
-import org.apache.sentry.binding.metastore.SentryMetastorePostEventListener;
import org.apache.sentry.core.model.db.DBModelAction;
import org.apache.sentry.core.model.db.DBModelAuthorizable;
import org.apache.sentry.core.model.db.DBModelAuthorizables;
@@ -520,13 +519,8 @@ public abstract class AbstractTestWithStaticConfiguration extends RulesForE2ETes
properties.put(HiveConf.ConfVars.METASTORE_EVENT_LISTENERS.varname,
"org.apache.hive.hcatalog.listener.DbNotificationListener");
} else {
- if (enableNotificationLog) {
- properties.put(HiveConf.ConfVars.METASTORE_EVENT_LISTENERS.varname,
- SentryMetastorePostEventListenerNotificationLog.class.getName());
- } else {
- properties.put(HiveConf.ConfVars.METASTORE_EVENT_LISTENERS.varname,
- SentryMetastorePostEventListener.class.getName());
- }
+ properties.put(HiveConf.ConfVars.METASTORE_EVENT_LISTENERS.varname,
+ SentryMetastorePostEventListenerNotificationLog.class.getName());
properties.put("hcatalog.message.factory.impl.json",
"org.apache.sentry.binding.metastore.messaging.json.SentryJSONMessageFactory");
}
http://git-wip-us.apache.org/repos/asf/sentry/blob/8a80d60b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java
----------------------------------------------------------------------
diff --git a/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java
index 6ab3391..c4be62d 100644
--- a/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java
+++ b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java
@@ -31,7 +31,6 @@ public class TestSentryListenerInBuiltDeserializer extends TestDBNotificationLis
public static void setupTestStaticConfiguration() throws Exception {
setMetastoreListener = true;
useDbNotificationListener = false;
- enableNotificationLog = true;
beforeClass();
}
}
http://git-wip-us.apache.org/repos/asf/sentry/blob/8a80d60b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java
----------------------------------------------------------------------
diff --git a/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java
index f33b2f3..3a404dd 100644
--- a/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java
+++ b/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java
@@ -55,7 +55,6 @@ public class TestSentryListenerSentryDeserializer extends AbstractMetastoreTestW
public static void setupTestStaticConfiguration() throws Exception {
setMetastoreListener = true;
useDbNotificationListener = false;
- enableNotificationLog = true;
AbstractMetastoreTestWithStaticConfiguration.setupTestStaticConfiguration();
setupClass();
}