You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/26 17:44:56 UTC

[GitHub] [skywalking] divyakumarjain opened a new issue #6846: Issue running Plugin test on macos

divyakumarjain opened a new issue #6846:
URL: https://github.com/apache/skywalking/issues/6846


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [X] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   
   ### Bug
   - Which version of SkyWalking, OS, and JRE?
   Skywalking 8.6 code on master branch, macos (Big Sur), JDK 1.8
   
   - Which company or project?
   Plugin test framework fails with run.sh failing to run sed command on macos
   
   - What happened?
   Run Plugin test on macos as per [link](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md#local-test-and-pull-request-to-the-upstream) on macos. it fails with error such as "invalid command .". After debugging for some time found that sed command used on between 145-156 in run.sh is not compatible on macos.
   
   Either the document needs to be updates to support linux only and remove macos or fix the run.sh script.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #6846: Issue running Plugin test on macos

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #6846:
URL: https://github.com/apache/skywalking/issues/6846#issuecomment-827199330


   This is a known issue of the script. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #6846: Issue running Plugin test on macos

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6846:
URL: https://github.com/apache/skywalking/issues/6846


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #6846: Issue running Plugin test on macos

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #6846:
URL: https://github.com/apache/skywalking/issues/6846#issuecomment-842978482


   @wu-sheng I submit a PR related to this issue, please help review the code at your convenience.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6846: Issue running Plugin test on macos

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6846:
URL: https://github.com/apache/skywalking/issues/6846#issuecomment-827215297


   @divyakumarjain Welcome to submit a patch to fix this script issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org