You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Jinmei Liao (Jira)" <ji...@apache.org> on 2022/05/12 20:47:00 UTC

[jira] [Comment Edited] (GEODE-10287) DistributedRegion.distributedRegionCleanup logic looks wrong

    [ https://issues.apache.org/jira/browse/GEODE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536337#comment-17536337 ] 

Jinmei Liao edited comment on GEODE-10287 at 5/12/22 8:46 PM:
--------------------------------------------------------------

If I close the distAdvisor after "waitForCurrentOperations()", the ConnectionCloseSSLTLSDUnitTest.connectionWithHungReaderIsCloseableAndUnhangsReader() will hang, that test will block the current operation, and make sure cache is still closable. If we waitForCurrentOperations before we close the distAdvisor, it will wait forever.

Recommend not to fix this for now and wait till I discuss more with [~dschneider] who filed this ticket.


was (Author: jinmeiliao):
If I close the distAdvisor after "waitForCurrentOperations()", the ConnectionCloseSSLTLSDUnitTest.connectionWithHungReaderIsCloseableAndUnhangsReader() will hang, that test will block the current operation, and make sure cache is still closable. If we waitForCurrentOperations before we close the distAdvisor, it will wait forever.

> DistributedRegion.distributedRegionCleanup logic looks wrong
> ------------------------------------------------------------
>
>                 Key: GEODE-10287
>                 URL: https://issues.apache.org/jira/browse/GEODE-10287
>             Project: Geode
>          Issue Type: Bug
>          Components: core
>            Reporter: Darrel Schneider
>            Assignee: Jinmei Liao
>            Priority: Major
>              Labels: needsTriage
>
> DistributedRegion.distributedRegionCleanup does this: distAdvisor.close(). Then a few lines later it calls "waitForCurrentOperations()". But waitForCurrentOperations uses the closed distAdvisor. Maybe it is okay to uses a closed distAdvisor but it seems better to call wait first and then close distAdvisor.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)