You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/08/12 00:13:30 UTC

Review Request 37374: Only accept v1 protobufs for HTTP API.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37374/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Repository: mesos


Description
-------

See above.


Diffs
-----

  src/master/http.cpp c2bc69fc07112ab0bcfde5dd110358eff811b7bc 
  src/master/master.hpp ef24bf869a0b0daf0e05d60f6b33c0aad1fb58a5 

Diff: https://reviews.apache.org/r/37374/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 37374: Only accept v1 protobufs for HTTP API.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37374/#review95022
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Aug. 11, 2015, 10:13 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37374/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 10:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See above.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp c2bc69fc07112ab0bcfde5dd110358eff811b7bc 
>   src/master/master.hpp ef24bf869a0b0daf0e05d60f6b33c0aad1fb58a5 
> 
> Diff: https://reviews.apache.org/r/37374/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 37374: Only accept v1 protobufs for HTTP API.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37374/#review95015
-----------------------------------------------------------

Ship it!


LGTM

- Anand Mazumdar


On Aug. 11, 2015, 10:13 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37374/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 10:13 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See above.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp c2bc69fc07112ab0bcfde5dd110358eff811b7bc 
>   src/master/master.hpp ef24bf869a0b0daf0e05d60f6b33c0aad1fb58a5 
> 
> Diff: https://reviews.apache.org/r/37374/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>