You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "wwbmmm (via GitHub)" <gi...@apache.org> on 2023/02/10 05:55:00 UTC

[GitHub] [brpc] wwbmmm opened a new pull request, #2121: Support c++20 coroutine

wwbmmm opened a new pull request, #2121:
URL: https://github.com/apache/brpc/pull/2121

   ### What problem does this PR solve?
   
   Issue Number:
   
   Problem Summary: Support c++20 coroutine
   
   ### What is changed and the side effects?
   
   Changed: New feature
   
   Side effects:
   - Performance effects(性能影响):No
   
   - Breaking backward compatibility(向后兼容性): No
   
   ---
   ### Check List:
   - Please make sure your changes are compilable(请确保你的更改可以通过编译).
   - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
   - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] Support c++20 coroutine (brpc)

Posted by "chenzhangyi (via GitHub)" <gi...@apache.org>.
chenzhangyi commented on PR #2121:
URL: https://github.com/apache/brpc/pull/2121#issuecomment-1434019020

   @wwbmmm 你可以加一个文档大概说一下实现原理和使用方式么(和当前直接用bthread的区别和注意事项)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] Support c++20 coroutine (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2121:
URL: https://github.com/apache/brpc/pull/2121#issuecomment-1511201564

   加了experimental命名空间


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] Support c++20 coroutine (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2121:
URL: https://github.com/apache/brpc/pull/2121#issuecomment-1434305917

   > @wwbmmm 你可以加一个文档大概说一下实现原理和使用方式么(和当前直接用bthread的区别和注意事项)
   
   已补充文档


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] Support c++20 coroutine (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2121:
URL: https://github.com/apache/brpc/pull/2121#issuecomment-1434026036

   > @wwbmmm 你可以加一个文档大概说一下实现原理和使用方式么(和当前直接用bthread的区别和注意事项)
   
   好的


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] Support c++20 coroutine (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm merged PR #2121:
URL: https://github.com/apache/brpc/pull/2121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] Support c++20 coroutine (brpc)

Posted by "stdpain (via GitHub)" <gi...@apache.org>.
stdpain commented on PR #2121:
URL: https://github.com/apache/brpc/pull/2121#issuecomment-1870886754

   如果调整系统的mmap_max_count，可以达到coroutine一样的效果吗


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] Support c++20 coroutine (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2121:
URL: https://github.com/apache/brpc/pull/2121#issuecomment-1882526381

   > 如果调整系统的mmap_max_count，可以达到coroutine一样的效果吗
   
   这样只是增加了bthread数量的上限。但是bthread的堆栈内存占用、堆栈切换开销还是会比coroutine更大。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org