[GitHub] [airflow] uranusjr commented on a diff in pull request #28457: Add deferrable mode to DataprocCreateBatchOperator

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #28457:
URL: https://github.com/apache/airflow/pull/28457#discussion_r1052188688


##########
airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -2071,17 +2073,21 @@ def __init__(
         region: str | None = None,
         project_id: str | None = None,
         batch: dict | Batch,
-        batch_id: str | None = None,
+        batch_id: str,
         request_id: str | None = None,
         retry: Retry | _MethodDefault = DEFAULT,
         timeout: float | None = None,
         metadata: Sequence[tuple[str, str]] = (),
         gcp_conn_id: str = "google_cloud_default",
         impersonation_chain: str | Sequence[str] | None = None,
         result_retry: Retry | _MethodDefault = DEFAULT,
+        deferrable: bool = False,
+        poll_interval: int = 5,
         **kwargs,
     ):
         super().__init__(**kwargs)
+        if deferrable and poll_interval <= 0:
+            raise ValueError("Invalid value for polling_interval_seconds. Expected value greater than 0")

Review Comment:
   Typo?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org