[GitHub] [arrow] davisusanibar commented on issue #34338: [Java] BaseAllocator.DEBUG should be opt-in as HistoricalLog is immensely expensive and breaks profiling

["davisusanibar (via GitHub)" <gi...@apache.org>]

davisusanibar commented on issue #34338:
URL: https://github.com/apache/arrow/issues/34338#issuecomment-1581201129

   Hi team,  I'm reviewing this issue.
   
   These are the ways implemented to handling logging messages:
   
   1. There is an environment variable created to enable debug messages `-Darrow.memory.debug.allocator`
   2. The fallback is that environment variable is not passed is to analyze if `-ea = enabled assertion` is declared
   3. In some another cases there is handled by `LOGGER.isDebugEnabled()` 
   
   My proposal will be to migrate all of these to only to be handled by external Logger and Configure SLF4J to see these logs (e.g. via Logback/Apache Log4j). It mean all Arrow Java logger messages should be handled by only SLF4J logger scope definition (debug(), info(), warn(), error()).
   
   
   1. There is an environment variable created to enable debug messages `-Darrow.memory.debug.allocator` ==> Will be moved to `logger.debug(...)`
   2. The fallback is that environment variable is not passed is to analyze if `-ea = enabled assertion` is declared ==> Will be deleted the logic to enable debug if `-ea` is passed
   3. In some another cases there is handled by `LOGGER.isDebugEnabled()` ==> Will be working as it is now
   4. Delete class `org.apache.arrow.memory.util.AssertionUtil`
   
   Please @lidavidm let me know your comments to try to implement that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org