[jira] [Commented] (FLINK-7070) Rework ScalaShellITCase#testSubmissionOfExternalLibraryStream

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072603#comment-16072603 ] 

ASF GitHub Bot commented on FLINK-7070:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/4249

    [FLINK-7070] Use properly built custom jar in ScalaShellITCase

    Before, the external jar loading tests where using the flink-ml jar
    without the scala shell package actually declaring this as a dependency.
    Now we built our own jar and have no unlisted dependencies anymore.
    
    R: @zentol 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink jira-7070-fix-scala-shell-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4249
    
----
commit c4e1d3a32a1ec833903a7a8ca479f3578d93b157
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2017-07-03T15:09:25Z

    [FLINK-7070] Use properly built custom jar in ScalaShellITCase
    
    Before, the external jar loading tests where using the flink-ml jar
    without the scala shell package actually declaring this as a dependency.
    Now we built our own jar and have no unlisted dependencies anymore.

----


> Rework ScalaShellITCase#testSubmissionOfExternalLibraryStream
> -------------------------------------------------------------
>
>                 Key: FLINK-7070
>                 URL: https://issues.apache.org/jira/browse/FLINK-7070
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala Shell, Tests
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.4.0
>
>
> The {{ScalaShellITCase}} makes use of flink-ml jar in one of it's tests. Since flink-ml is not even declared as a dependency the test only works because by coincidence flink-ml is build before flink-scala-shell.
> {code}
>   @Test
>   def testSubmissionOfExternalLibraryBatch: Unit = {
>   ...
>   val folder = findLibraryFolder(
>     "../flink-libraries/flink-ml/target/",
>     "../../flink-libraries/flink-ml/target/")
>   ...
>   }
>   def findLibraryFolder(paths: String*): File = {
>     for (path <- paths) {
>       val folder = new File(path)
>       if (folder.exists()) {
>         return folder
>       }
>     }
>     throw new RuntimeException("Library folder not found in any of the supplied paths!")
>   }
> {code}
> At the very least we should declare the dependency, or even better rework this test to rely on a custom jar built in flink-scala-shell to reduce dependencies.
> Also, the exception message in {{findLibraryFolder}} should contain the folder it couldn't find.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)