You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/01 22:57:05 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2130: Upgrade helix-front to Angular 11.2
micahstubbs opened a new pull request, #2130:
URL: https://github.com/apache/helix/pull/2130
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fix #2105
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR upgrades helix-front to Angular 11.2.
This PR completely contains earlier helix-front upgrade PRs #2104, #2094, #2092, #2087, #2083, and #2078. These previous Angular major-version PRs should be merged first.
### Tests
Let's test the upgrade from Angular 10.2 to Angular 11.2.
- [x] `npm install` works
- [x] `npm run type:check:watch` shows 0 TypeScript errors
- [x] `npm run lint` runs and passes `All files pass linting.`
- [x] `npm run build` works
- [x] `npm start` works, with 0 errors in the browser console.
- [x] `npm run test` runs and passes.
`npm start` works as expected, and recognizes our proxy config in `proxy.conf.json`.
<img width="723" alt="Screen Shot 2022-05-23 at 5 44 20 PM" src="https://user-images.githubusercontent.com/2119400/169926267-e571984c-a825-4bb6-b340-2d4424644990.png">
Helix UI renders with 0 errors and 2 warnings in the browser console. The warning is understandable since the piwik telemetry library is not configured.
`npm run test` results
<img width="858" alt="Screen Shot 2022-05-23 at 5 46 32 PM" src="https://user-images.githubusercontent.com/2119400/169926445-6ec33fba-0a2a-4974-a9b7-e98e38b31899.png">
### Documentation
- [x] In case of new functionality, my PR adds documentation in the following wiki page:
Not applicable since this PR does not contain new functionality, only tooling and dependency upgrades.
### Code Quality
- [x] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
Not applicable since this PR does not make any changes to the Java codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 merged pull request #2130: Upgrade helix-front to Angular 11.2
Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2130:
URL: https://github.com/apache/helix/pull/2130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] somecodemonkey commented on pull request #2130: Upgrade helix-front to Angular 11.2
Posted by GitBox <gi...@apache.org>.
somecodemonkey commented on PR #2130:
URL: https://github.com/apache/helix/pull/2130#issuecomment-1145497154
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2130: Upgrade helix-front to Angular 11.2
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2130:
URL: https://github.com/apache/helix/pull/2130#issuecomment-1145525287
This PR is ready to be merged, approved by @somecodemonkey
Final commit message:
## Upgrade helix-front to Angular 11.2 Fix #2105
Fix security vulnerabilities in helix-front dependencies.
Upgrade helix-front dependencies to improve contributor productivity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2130: Upgrade helix-front to Angular 11.2
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2130:
URL: https://github.com/apache/helix/pull/2130#issuecomment-1145403601
@somecodemonkey this PR is ready for your review. Thanks for sharing your frontend expertise!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org