[jira] [Updated] (SOLR-4634) Fix test bugs in Javascript tests to work with Java 8's Mozilla-Rhino-replacement "Nashorn"

["Uwe Schindler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated SOLR-4634:
--------------------------------

    Attachment: SOLR-4634.patch

This patch fixes both issues and another tye error in DIH:
- The fix was to cast to Number and not expect a specific number type
- In DIH there was a wrong String type expected
- the problem with assertNotNull not found was a preexisting bug in the script: It tried to call a static method (Assert.assertNotNull) on an instance, which is not allowed by "corect" javascript. I fixed this by directly using org.junit.Assert.
                
> Fix test bugs in Javascript tests to work with Java 8's Mozilla-Rhino-replacement "Nashorn"
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4634
>                 URL: https://issues.apache.org/jira/browse/SOLR-4634
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Uwe Schindler
>         Attachments: SOLR-4634.patch
>
>
> the new Java 8 builds have replaced "Mozilla Rhino" JavaScript engine with "Nashorn" (http://openjdk.java.net/projects/nashorn/). The tests assume that a specific java type is returned, which is not guaranteed and Rhino-specific. Instead it should only cast to java.lang.Number and not to a specific type. The reason for the difference: Javascript is typeless, it only knows numbers, but not double/integer/...
> The other bug is not explainable to me, I think its some other problem. Il will fix the first one.
> The following tests fail, mostly with "java.lang.Integer cannot be casted to java.lang.Double":
> - org.apache.solr.update.processor.ScriptEngineTest.testEvalText
> - org.apache.solr.update.processor.ScriptEngineTest.testPut
> - org.apache.solr.update.processor.ScriptEngineTest.testEvalReader
> Those fail with some assert problem (method not found, I think the javascript is bogus):
> - org.apache.solr.update.processor.StatelessScriptUpdateProcessorFactoryTest.testSingleScript
> - org.apache.solr.update.processor.StatelessScriptUpdateProcessorFactoryTest.testMultipleScripts

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org