Re: Overhauling mod_rewrite !!

["Ralf S. Engelschall" <rs...@engelschall.com>]

In article <97...@paris.ics.uci.edu> you wrote:

> I think it is a good idea to do this reorganization of mod_rewrite
> now rather than later.  Splitting it up into different files is
> equivalent to reformatting, except in the production of new makefiles.

> Making changes to the code at the same time as splitting it up is
> generally a bad idea (like Ken said) and it would be nice if you
> could split a baseline version first (e.g., the copy included with 1.3b2)
> and then apply the code changes since that baseline to the new files.
> That would give us a version history of the code changes.  OTOH, that
> is extra work, and I'd rather see the file split happen than hold it
> back just to make the version history available.

> The reason I think it should be done now is because mod_rewrite is
> currently in a state where only Ralf can understand how it works.
> If we break it up to be more understandable by people who are not the
> original author, then I think we'll have better luck developing a 2.0
> architecture that fits its needs.  This is the same reason why I supported
> the reorg of the vhost code.

> My only request is that one of the NT-clueful folks volunteer to fix
> the NT build at the same time as Ralf commits the changes (i.e., you
> guys need to coordinate so that the changes get committed on a day
> in which an NT person is available to fix and commit the NT makefiles).

Ok, I'll do the following:

1. Post the [PATCH] message containing the new
   apply_rewrite_rule() function which 
   - is totally rewritten and commented, so
     anyone beside RSE should be able to understand it now.
   - fixes the recently discovered bugs by avoiding
     special redundant cases and by reorganising the
     engines data flow.
   [will be done today for 1.3b3]

2. Do the missing source style guide changes (only line
   wrapping and comment changes for mod_rewrite as I see)
   [will be done at the weekend for 1.3b3]

3. Start again to split the code into modules/rewrite/.
   Because of the two points above I've stopped this
   splitting last week.
   [will be done in the next few weeks when I find time
    but needs not be done for 1.3b3 but for 1.3 final]

This this ok this way?

Greetings,
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Re: Overhauling mod_rewrite !!

[Dean Gaudet <dg...@arctic.org>]

On Tue, 4 Nov 1997, Ralf S. Engelschall wrote:

> This this ok this way?

It sounds good to me.

Dean