You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/07/31 17:03:56 UTC
[GitHub] [ozone] dombizita opened a new pull request, #3641: HDDS-7047. Add Recon to ozone-topology sample compose environment
dombizita opened a new pull request, #3641:
URL: https://github.com/apache/ozone/pull/3641
## What changes were proposed in this pull request?
I added Recon as a service to the `compose/ozone-topology` environment. I also added the Recon robot tests to the test.sh in the ozone-topology folder.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7047
## How was this patch tested?
I tested it in the `compose/ozone-topology` environment via docker and run the test.sh locally.
https://github.com/dombizita/ozone/actions/runs/2769844964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #3641: HDDS-7047. Add Recon to ozone-topology sample compose environment
Posted by GitBox <gi...@apache.org>.
dombizita commented on code in PR #3641:
URL: https://github.com/apache/ozone/pull/3641#discussion_r940202753
##########
hadoop-ozone/dist/src/main/compose/ozone-topology/docker-compose.yaml:
##########
@@ -147,6 +147,22 @@ services:
networks:
net:
ipv4_address: 10.5.0.71
+ recon:
+ image: ${OZONE_RUNNER_IMAGE}:${OZONE_RUNNER_VERSION}
+ privileged: true #required by the profiler
+ volumes:
+ - ../..:/opt/hadoop
+ ports:
+ - 9888:9888
+ env_file:
+ - docker-config
Review Comment:
Thanks for noticing this, I updated my patch with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3641: HDDS-7047. Add Recon to ozone-topology sample compose environment
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3641:
URL: https://github.com/apache/ozone/pull/3641#discussion_r936022151
##########
hadoop-ozone/dist/src/main/compose/ozone-topology/docker-compose.yaml:
##########
@@ -147,6 +147,22 @@ services:
networks:
net:
ipv4_address: 10.5.0.71
+ recon:
+ image: ${OZONE_RUNNER_IMAGE}:${OZONE_RUNNER_VERSION}
+ privileged: true #required by the profiler
+ volumes:
+ - ../..:/opt/hadoop
+ ports:
+ - 9888:9888
+ env_file:
+ - docker-config
Review Comment:
nit
```suggestion
- ./docker-config
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3641: HDDS-7047. Add Recon to ozone-topology sample compose environment
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3641:
URL: https://github.com/apache/ozone/pull/3641#discussion_r936304061
##########
hadoop-ozone/dist/src/main/compose/ozone-topology/docker-compose.yaml:
##########
@@ -147,6 +147,22 @@ services:
networks:
net:
ipv4_address: 10.5.0.71
+ recon:
+ image: ${OZONE_RUNNER_IMAGE}:${OZONE_RUNNER_VERSION}
+ privileged: true #required by the profiler
+ volumes:
+ - ../..:/opt/hadoop
+ ports:
+ - 9888:9888
+ env_file:
+ - docker-config
Review Comment:
@smengcl are you suggesting this for consistency with the rest of the services in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3641: HDDS-7047. Add Recon to ozone-topology sample compose environment
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3641:
URL: https://github.com/apache/ozone/pull/3641#discussion_r936324218
##########
hadoop-ozone/dist/src/main/compose/ozone-topology/docker-compose.yaml:
##########
@@ -147,6 +147,22 @@ services:
networks:
net:
ipv4_address: 10.5.0.71
+ recon:
+ image: ${OZONE_RUNNER_IMAGE}:${OZONE_RUNNER_VERSION}
+ privileged: true #required by the profiler
+ volumes:
+ - ../..:/opt/hadoop
+ ports:
+ - 9888:9888
+ env_file:
+ - docker-config
Review Comment:
Ah, yes. Though it is [not strictly necessary](https://docs.docker.com/compose/environment-variables/#the-env_file-configuration-option) (unlike `volume` when we want to map a file from current working directory)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #3641: HDDS-7047. Add Recon to ozone-topology sample compose environment
Posted by GitBox <gi...@apache.org>.
dombizita commented on code in PR #3641:
URL: https://github.com/apache/ozone/pull/3641#discussion_r940202062
##########
hadoop-ozone/dist/src/main/compose/ozone-topology/docker-compose.yaml:
##########
@@ -147,6 +147,22 @@ services:
networks:
net:
ipv4_address: 10.5.0.71
+ recon:
+ image: ${OZONE_RUNNER_IMAGE}:${OZONE_RUNNER_VERSION}
+ privileged: true #required by the profiler
+ volumes:
+ - ../..:/opt/hadoop
+ ports:
+ - 9888:9888
+ env_file:
+ - docker-config
+ environment:
+ OZONE-SITE.XML_ozone.replication: ${OZONE_REPLICATION_FACTOR:-1}
Review Comment:
Thanks for explaining this, I updated my patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta merged pull request #3641: HDDS-7047. Add Recon to ozone-topology sample compose environment
Posted by GitBox <gi...@apache.org>.
fapifta merged PR #3641:
URL: https://github.com/apache/ozone/pull/3641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3641: HDDS-7047. Add Recon to ozone-topology sample compose environment
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3641:
URL: https://github.com/apache/ozone/pull/3641#discussion_r934236004
##########
hadoop-ozone/dist/src/main/compose/ozone-topology/docker-compose.yaml:
##########
@@ -147,6 +147,22 @@ services:
networks:
net:
ipv4_address: 10.5.0.71
+ recon:
+ image: ${OZONE_RUNNER_IMAGE}:${OZONE_RUNNER_VERSION}
+ privileged: true #required by the profiler
+ volumes:
+ - ../..:/opt/hadoop
+ ports:
+ - 9888:9888
+ env_file:
+ - docker-config
+ environment:
+ OZONE-SITE.XML_ozone.replication: ${OZONE_REPLICATION_FACTOR:-1}
Review Comment:
`OZONE_REPLICATION_FACTOR` lets us use scalable environments (`ozone`, `ozone-ha`, etc.) with a single datanode by default, and scale to 3 if needed. It is not applicable to the `ozone-topology` environment. With a fixed set of 6 datanodes it is configured as:
https://github.com/apache/ozone/blob/511977ad67324cee8603706f9b76244d58808f01/hadoop-ozone/dist/src/main/compose/ozone-topology/docker-config#L32
So we can remove this extra config:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org