You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2023/04/12 13:19:43 UTC

[GitHub] [camel-k] squakez opened a new pull request, #4247: fix: won't panic on error handler validation failure

squakez opened a new pull request, #4247:
URL: https://github.com/apache/camel-k/pull/4247

   Introduced a validation for each kind of error handler.
   
   With this PR we make sure that every error handler type is validated against the expected configuration. `Validate()` func need to be configured for each type according the logic required for it (in this case it seems only the `sink` requires some validation).
   
   Closes #3586
   
   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   fix: won't panic on error handler validation failure
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez merged pull request #4247: fix: won't panic on error handler validation failure

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4247:
URL: https://github.com/apache/camel-k/pull/4247


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez commented on pull request #4247: fix: won't panic on error handler validation failure

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4247:
URL: https://github.com/apache/camel-k/pull/4247#issuecomment-1505269204

   @essobedo with this one we should take care of providing the expected validation logic for each error handler type and fail during parse. It's a bit different on the first work you did on #3595, if you want to give a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org