You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/10/25 01:30:03 UTC
[GitHub] rhtyd commented on a change in pull request #2905: Fix delete
domain button in the UI to update only after deleteDomain job finishes
rhtyd commented on a change in pull request #2905: Fix delete domain button in the UI to update only after deleteDomain job finishes
URL: https://github.com/apache/cloudstack/pull/2905#discussion_r228010449
##########
File path: ui/scripts/domains.js
##########
@@ -69,11 +69,23 @@
async: false,
success: function(json) {
var jid = json.deletedomainresponse.jobid;
+ var wasDomainDeletedWithSuccess = false;
+ $.ajax({
+ url: createURL("queryAsyncJobResult&jobId=" + jid),
+ dataType: "json",
+ async: false,
Review comment:
async `false` will block the UI... is there a way to have this but without blocking the UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services