[GitHub] [incubator-tvm] liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect

[GitBox <gi...@apache.org>]

liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect
URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367195032
 
 

 ##########
 File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
 ##########
 @@ -21,52 +21,95 @@
 
 import numpy as np
 from tvm import relay
-from tvm.relay.qnn.op.qnn import dequantize
+from tvm.relay.qnn.op.qnn import quantize, dequantize
 
-zero_centered_uint8_quantized_range = np.float32(255)
-zero_centered_int8_quantized_range = np.float32(127)
+zero_centered_uint8_quantized_range = np.float32(255.5)
 
 Review comment:
   Can you explain why are we adding an extra 0.5 here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services