[GitHub] [spark] icexelloss commented on a change in pull request #24844: [SPARK-28003][PYTHON] Allow NaT values when creating Spark dataframe from pandas with Arrow

[GitBox <gi...@apache.org>]

icexelloss commented on a change in pull request #24844: [SPARK-28003][PYTHON] Allow NaT values when creating Spark dataframe from pandas with Arrow
URL: https://github.com/apache/spark/pull/24844#discussion_r292647454
 
 

 ##########
 File path: python/pyspark/serializers.py
 ##########
 @@ -296,7 +296,7 @@ def create_array(s, t):
             mask = s.isnull()
             # Ensure timestamp series are in expected form for Spark internal representation
             if t is not None and pa.types.is_timestamp(t):
-                s = _check_series_convert_timestamps_internal(s.fillna(0), self._timezone)
+                s = _check_series_convert_timestamps_internal(s, self._timezone)
 
 Review comment:
   Removing this doesn't fail existing tests. @BryanCutler do you remember why are we doing `fillna(0)` here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org