You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/06 05:54:17 UTC
[GitHub] [nifi] wanghongqi opened a new pull request #4185: NIFI-7313:fix
bug on 'Quote Table Identifiers'
wanghongqi opened a new pull request #4185: NIFI-7313:fix bug on 'Quote Table Identifiers'
URL: https://github.com/apache/nifi/pull/4185
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] wanghongqi commented on issue #4185: NIFI-7313:fix bug on
'Quote Table Identifiers'
Posted by GitBox <gi...@apache.org>.
wanghongqi commented on issue #4185: NIFI-7313:fix bug on 'Quote Table Identifiers'
URL: https://github.com/apache/nifi/pull/4185#issuecomment-615903627
> Can you revert the Splunk related change and squash your commits? Thanks @wanghongqi
I revert the Splunk related change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] wanghongqi edited a comment on issue #4185: NIFI-7313:fix
bug on 'Quote Table Identifiers'
Posted by GitBox <gi...@apache.org>.
wanghongqi edited a comment on issue #4185: NIFI-7313:fix bug on 'Quote Table Identifiers'
URL: https://github.com/apache/nifi/pull/4185#issuecomment-615903627
> Can you revert the Splunk related change and squash your commits? Thanks @wanghongqi
I revert the Splunk related change .
I only one commits,It's not need squash,I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] wanghongqi commented on issue #4185: NIFI-7313:fix bug on
'Quote Table Identifiers'
Posted by GitBox <gi...@apache.org>.
wanghongqi commented on issue #4185: NIFI-7313:fix bug on 'Quote Table Identifiers'
URL: https://github.com/apache/nifi/pull/4185#issuecomment-615371223
ok.I will do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] pvillard31 commented on issue #4185: NIFI-7313:fix bug on
'Quote Table Identifiers'
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on issue #4185: NIFI-7313:fix bug on 'Quote Table Identifiers'
URL: https://github.com/apache/nifi/pull/4185#issuecomment-615274505
Can you revert the Splunk related change and squash your commits? Thanks @wanghongqi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services