[jira] [Work logged] (BEAM-9642) Add SDF execution-time runners

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-9642?focusedWorklogId=414228&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414228 ]

ASF GitHub Bot logged work on BEAM-9642:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/20 18:53
            Start Date: 01/Apr/20 18:53
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on pull request #11257: [BEAM-9642] Create runtime invokers for SDF methods.
URL: https://github.com/apache/beam/pull/11257#discussion_r400528303
 
 

 ##########
 File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers.go
 ##########
 @@ -23,29 +23,36 @@ import (
 	"reflect"
 )
 
-func invokeCreateInitialRestriction(fn *funcx.Fn, elms *FullValue) (rest interface{}, err error) {
+func createInitialRestrictionCallFn(fn *funcx.Fn) (callFn func(*FullValue) interface{}, err error) {
 
 Review comment:
   I'm surprised that the return func type doesn't have the return value pair wrapped in (), but if gofmt likes it' it's fine.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 414228)
    Time Spent: 20m  (was: 10m)

> Add SDF execution-time runners
> ------------------------------
>
>                 Key: BEAM-9642
>                 URL: https://issues.apache.org/jira/browse/BEAM-9642
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Adds execution-time SDF runner units to the exec package, and any unit tests + helpers required.
> This is needed to get the expanded SDF URNs to execute in the runner harness.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)