You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2017/06/05 13:06:48 UTC

[GitHub] brooklyn-client pull request #53: show bundle info and message when doing `c...

GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-client/pull/53

    show bundle info and message when doing `catalog add`

    also supports backwards compatibility as only some API methods support the detail

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-client catalog-bundle-info

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-client/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit a245052a7e22e426fde4d0c1e1d62fd7105bacc2
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2017-06-05T12:35:02Z

    show bundle info and message when doing `catalog add`
    
    also supports backwards compatibility as only some API methods support the detail

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client issue #53: show bundle info and message when doing `catalog ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/brooklyn-client/pull/53
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/brooklyn-client-pull-requests/132/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client issue #53: show bundle info and message when doing `catalog ...

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-client/pull/53
  
    Looks good to me too!   Sorry about late review but wouldn't have had any comments anyway :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client issue #53: show bundle info and message when doing `catalog ...

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-client/pull/53
  
    @geomacy as discussed at https://github.com/apache/brooklyn-server/pull/672#issuecomment-306182000 (and this PR only does anything with that merged, else it is safe but no-op) this supports displaying the additional message eg
    
    ```
    % target/br catalog add file:///tmp/test672a.zip
    Updated io.cloudsoft.cli44:0.12.0.SNAPSHOT as existing ID kbhxoi0ln4
    * myTestEnt:0.12.0.SNAPSHOT
    * myOtherTest:0.12.0.SNAPSHOT
    * testent1:0.12.0.SNAPSHOT
    ```
    
    instead of
    
    ```
    % target/br catalog add file:///tmp/test672a.zip
    myTestEnt:0.12.0.SNAPSHOT
    myOtherTest:0.12.0.SNAPSHOT
    testent1:0.12.0.SNAPSHOT
    ```
    
    but falling back to that latter output if detail isn't available (old server version, or not uploading a bundle/directory)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request #53: show bundle info and message when doing `c...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-client/pull/53


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---