You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by tylertreat-wf <gi...@git.apache.org> on 2016/04/01 18:34:52 UTC
[GitHub] thrift pull request: THRIFT-3771 TBufferedTransport gets in invali...
GitHub user tylertreat-wf opened a pull request:
https://github.com/apache/thrift/pull/973
THRIFT-3771 TBufferedTransport gets in invalid state on read/write errors
Go's TBufferedTransport can enter an invalid state after an error occurs
while calling read, write, or flush. This is because TBufferedTransport
uses a bufio.ReadWriter, which "caches" the error returned by a call to
read or write such that subsequent calls return the same error. This can
be problematic if you wish to reuse the transport after a failed read or
write. The solution is to reset the reader/writer on failed calls.
@stevenosborne-wf @markerickson-wf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tylertreat-wf/thrift THRIFT-3771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/973.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #973
----
commit 0b7723664b12ee86c003f76bd19bee722f4bbb7f
Author: Tyler Treat <ty...@webfilings.com>
Date: 2016-04-01T16:33:20Z
THRIFT-3771 TBufferedTransport gets in invalid state on read/write errors
Go's TBufferedTransport can enter an invalid state after an error occurs
while calling read, write, or flush. This is because TBufferedTransport
uses a bufio.ReadWriter, which "caches" the error returned by a call to
read or write such that subsequent calls return the same error. This can
be problematic if you wish to reuse the transport after a failed read or
write. The solution is to reset the reader/writer on failed calls.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3771 TBufferedTransport gets in invali...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3771 TBufferedTransport gets in invali...
Posted by stevenosborne-wf <gi...@git.apache.org>.
Github user stevenosborne-wf commented on the pull request:
https://github.com/apache/thrift/pull/973#issuecomment-204463611
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---