You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liugddx (via GitHub)" <gi...@apache.org> on 2026/08/26 00:10:02 UTC
[PR] test(desktop): await Plan turn settlement [maka]
liugddx opened a new pull request, #3836:
URL: https://github.com/apache/maka/pull/3836
## Summary
Stabilize the Plan/catalog-refresh Desktop e2e scenarios by waiting for Runtime Host's authoritative terminal turn ownership before latching the next session-catalog read.
- adds one shared barrier that requires `runningTurnIds` to be known-empty;
- applies it to the four Plan scenarios that first create a session through the fake backend;
- preserves the existing pending refresh, rejected refresh, queued latest-intent, and deletion-race assertions.
## Why
The fake backend response can become visible before Runtime Host publishes terminal turn ownership. The tests previously treated that text as a completion barrier, then observed the Plan row enabled briefly before a late running projection disabled it between the assertion and click.
This reproduced on two unrelated #3789 heads:
- [run 32867280955](https://github.com/apache/maka/actions/runs/32867280955/job/97865535723) timed out on the second Plan click in the latest-intent scenario;
- [run 32870919058](https://github.com/apache/maka/actions/runs/32870919058/job/97877439151) timed out on the first Plan click in the committed-state scenario.
The new barrier uses the same known-empty `runningTurnIds` authority already used by the Desktop streaming e2e suite. It runs before `sessions.list` is latched, so the latch still owns only the Plan commit's catalog refresh.
## Verification
- `npm run lint`
- `npm run format:check`
- `npm run build`
- `npm run typecheck`
- `npx knip --workspace apps/desktop`
- `git diff --check`
- Playwright discovery compiles and selects the focused scenario correctly.
Local Windows Electron did not create its first test window, so the focused runtime assertion requires the hosted Linux/xvfb CI lane. The failure occurred before the test body and is not counted as passing evidence.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool and scope: Codex analyzed the two hosted traces, added the test-only settlement barrier, and ran the listed local gates.
Fixes #3814.
## Checklist
- [x] Tests cover the timing boundary that failed in hosted CI
- [x] Lint, format, build, typecheck, knip, and diff checks pass locally
- [ ] Hosted `test` passes on the exact PR head
Does this PR entail a change in behavior?
- [ ] Yes
- [x] No - this changes only Desktop e2e synchronization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(desktop): await Plan turn settlement [maka]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #3836:
URL: https://github.com/apache/maka/pull/3836#issuecomment-5419327909
Fresh exact-head est is green on 62c5756e after rebasing onto main=8ff9528eb, including the full Desktop e2e suite. #3814 is ready for maintainer review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(desktop): await Plan turn settlement [maka]
Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter merged PR #3836:
URL: https://github.com/apache/maka/pull/3836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(desktop): await Plan turn settlement [maka]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #3836:
URL: https://github.com/apache/maka/pull/3836#issuecomment-5418815724
@Astro-Han Hosted exact-head test is green, including the complete Desktop e2e suite. This PR keeps the existing catalog-failure assertions and adds only the authoritative runningTurnIds settlement barrier before the latch. Could you please review when available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(desktop): await Plan turn settlement [maka]
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #3836:
URL: https://github.com/apache/maka/pull/3836#issuecomment-5419335030
@Astro-Han Current exact head 62c5756e is rebased onto main=8ff9528eb. Hosted est run 32918399089 is green, including all Desktop e2e tests. The barrier is test-only and #3814 remains open until this PR merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org