You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2024/10/25 05:35:45 UTC
[PR] refactor: update and simplify some dependencies [cordova-js]
dpogue opened a new pull request, #281:
URL: https://github.com/apache/cordova-js/pull/281
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Since we can't adopt the latest versions of execa and globby due to ESM, and we use them for very specific purposes here, replace them with built-ins where possible (and use fast-glob where not possible).
### Description
<!-- Describe your changes in detail -->
- Replace the single `execa` call with `child_process.spawnSync`, since we know that we're invoking `git` rather than a shell script
- Replace the one spot that used `globby` with `fast-glob`
- On versions of node with `fs.globSync`, use that instead of `fast-glob`
- Fix a warning in a Jasmine test about `done` getting called with arguments
- Update testing dependencies to latest versions
### Testing
<!-- Please describe in detail how you tested your changes. -->
- Confirmed that the contents of the cordova.js file are the same before and after these changes (some extra spaces removed, but no code changes)
- Confirmed that all unit tests run and pass
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] refactor: update and simplify some dependencies [cordova-js]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #281:
URL: https://github.com/apache/cordova-js/pull/281#issuecomment-2436878255
## [Codecov](https://app.codecov.io/gh/apache/cordova-js/pull/281?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 83.62%. Comparing base [(`d77f379`)](https://app.codecov.io/gh/apache/cordova-js/commit/d77f3795e59e25150c0f25739c2dac71684dd902?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`621c944`)](https://app.codecov.io/gh/apache/cordova-js/commit/621c94449250eb355a917c36af75ed5a22fa01bf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 83.62% 83.62%
=======================================
Files 14 14
Lines 519 519
=======================================
Hits 434 434
Misses 85 85
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-js/pull/281?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] refactor: update and simplify some dependencies [cordova-js]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue merged PR #281:
URL: https://github.com/apache/cordova-js/pull/281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org