You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2013/07/13 00:08:28 UTC

[jclouds-labs] JCLOUDS-188: Include pagination parameters in Abiquo VirtualMachineTemplateOptions (#15)

* Modified the Abiquo VirtualMachineTemplateOptions builder to inherit from the BaseFilterOptionsBuilder so it can accept pagination parameters.
* Also superseded the OrderBy enum by a simple String, to avoid hardcoding the fields that are suitable to be sorted.
* The OrderBy enum has been removed and the FilterOptions class moved to a more convenient package.
You can merge this Pull Request by running:

  git pull https://github.com/nacx/jclouds-labs 188-template-pagination

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs/pull/15

-- Commit Summary --

  * JCLOUDS-188: Include pagination parameters in Abiquo VirtualMachineTemplateOptions

-- File Changes --

    M abiquo/src/main/java/org/jclouds/abiquo/domain/cloud/options/VirtualMachineOptions.java (2)
    M abiquo/src/main/java/org/jclouds/abiquo/domain/cloud/options/VirtualMachineTemplateOptions.java (5)
    M abiquo/src/main/java/org/jclouds/abiquo/domain/cloud/options/VolumeOptions.java (3)
    M abiquo/src/main/java/org/jclouds/abiquo/domain/enterprise/options/EnterpriseOptions.java (2)
    M abiquo/src/main/java/org/jclouds/abiquo/domain/event/options/EventOptions.java (2)
    M abiquo/src/main/java/org/jclouds/abiquo/domain/network/options/IpOptions.java (2)
    R abiquo/src/main/java/org/jclouds/abiquo/domain/options/FilterOptions.java (9)
    D abiquo/src/main/java/org/jclouds/abiquo/domain/options/search/reference/OrderBy.java (38)
    M abiquo/src/test/java/org/jclouds/abiquo/features/CloudApiTest.java (3)
    M abiquo/src/test/java/org/jclouds/abiquo/features/EnterpriseApiTest.java (3)
    A abiquo/src/test/java/org/jclouds/abiquo/features/VirtualMachineTemplateApiExpectTest.java (77)
    A abiquo/src/test/resources/payloads/templates-page.xml (35)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/15.patch
https://github.com/jclouds/jclouds-labs/pull/15.diff

Re: [jclouds-labs] JCLOUDS-188: Include pagination parameters in Abiquo VirtualMachineTemplateOptions (#15)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-pull-requests #15](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/15/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/15#issuecomment-20907631

Re: [jclouds-labs] JCLOUDS-188: Include pagination parameters in Abiquo VirtualMachineTemplateOptions (#15)

Posted by Ignasi Barrera <no...@github.com>.

Merged

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/15#issuecomment-21236515

Re: [jclouds-labs] JCLOUDS-188: Include pagination parameters in Abiquo VirtualMachineTemplateOptions (#15)

Posted by Ignasi Barrera <no...@github.com>.

Closed #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/15

Re: [jclouds-labs] JCLOUDS-188: Include pagination parameters in Abiquo VirtualMachineTemplateOptions (#15)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs #195](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/195/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/15#issuecomment-20907461