You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/15 11:42:27 UTC
[GitHub] [lucene-solr-operator] jward-bw opened a new pull request #216: NT: Allow the definition of multiple imagePullSecrets.
jward-bw opened a new pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216
Currently you can only specify a single imagePullSecret in the ContainerImage, for the SolrImage in SolrCloudSpec. This allows a user to define any number of imagePullSecrets, which is required if initContainers or sidecarContainers need different imagePullSecrets to the SolrImage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] jward-bw commented on pull request #216: NT: Allow the definition of multiple imagePullSecrets.
Posted by GitBox <gi...@apache.org>.
jward-bw commented on pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216#issuecomment-779203863
Sorry for the multiple failed runs, didn't read the docs enough on building the manifests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman merged pull request #216: NT: Allow the definition of multiple imagePullSecrets.
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] jward-bw commented on pull request #216: NT: Allow the definition of multiple imagePullSecrets.
Posted by GitBox <gi...@apache.org>.
jward-bw commented on pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216#issuecomment-779755262
> Are you using the kustomize version specified in hack/install_dependencies.sh?
Yep that was the issue, I had an older version installed.
> ... implement the functionality in the prometheusExporter code as well?
Done!
> Would you mind adding a test for this?
Sorry this is my first time writing go code, and I'm not familiar with the testing structure. Where should tests for these changes go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] jward-bw commented on a change in pull request #216: NT: Allow the definition of multiple imagePullSecrets.
Posted by GitBox <gi...@apache.org>.
jward-bw commented on a change in pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216#discussion_r576728102
##########
File path: controllers/util/solr_util.go
##########
@@ -520,8 +520,15 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.SolrCl
}
if solrCloud.Spec.SolrImage.ImagePullSecret != "" {
- stateful.Spec.Template.Spec.ImagePullSecrets = []corev1.LocalObjectReference{
- {Name: solrCloud.Spec.SolrImage.ImagePullSecret},
+ if nil != customPodOptions {
+ stateful.Spec.Template.Spec.ImagePullSecrets = append(
+ customPodOptions.ImagePullSecrets,
Review comment:
Fixed! Thanks for pointing that out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] jward-bw closed pull request #216: NT: Allow the definition of multiple imagePullSecrets.
Posted by GitBox <gi...@apache.org>.
jward-bw closed pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] jward-bw commented on pull request #216: NT: Allow the definition of multiple imagePullSecrets.
Posted by GitBox <gi...@apache.org>.
jward-bw commented on pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216#issuecomment-780515319
> As for the tests, here is some help:
Thanks so much for the pointers Houston, let me know if I've missed anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] jward-bw commented on pull request #216: NT: Allow the definition of multiple imagePullSecrets.
Posted by GitBox <gi...@apache.org>.
jward-bw commented on pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216#issuecomment-779251617
Was I supposed to add `helm/solr-operator/crds/crds.yaml` to my commit? A diff that size smells suspiscious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #216: NT: Allow the definition of multiple imagePullSecrets.
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216#discussion_r576354516
##########
File path: controllers/util/solr_util.go
##########
@@ -520,8 +520,15 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.SolrCl
}
if solrCloud.Spec.SolrImage.ImagePullSecret != "" {
- stateful.Spec.Template.Spec.ImagePullSecrets = []corev1.LocalObjectReference{
- {Name: solrCloud.Spec.SolrImage.ImagePullSecret},
+ if nil != customPodOptions {
+ stateful.Spec.Template.Spec.ImagePullSecrets = append(
+ customPodOptions.ImagePullSecrets,
Review comment:
I think customPodOptions secrets will only be added if the `SolrImage.ImagePullSecret` is provided. You should probably have it added in a separate if statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org