You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "parisni (via GitHub)" <gi...@apache.org> on 2023/04/11 20:28:33 UTC
[GitHub] [hudi] parisni opened a new pull request, #8432: Fix NPE when upsert merger and null map or array
parisni opened a new pull request, #8432:
URL: https://github.com/apache/hudi/pull/8432
### Change Logs
Fixes #8431
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
none
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1521064185
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a59cd66283dafe08691023f579f4cadb6308d63f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1524476805
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1504253664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4502dad350e0dc84299dc0bd5889506420b0f49 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1525919896
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
}, {
"hash" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693",
"triggerID" : "1524476805",
"triggerType" : "MANUAL"
}, {
"hash" : "22fb6052ee84211a79a360d04600c98697d80afa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16710",
"triggerID" : "22fb6052ee84211a79a360d04600c98697d80afa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e9388ee9a6edaa6caab4f738b093f82744bc7dc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693)
* 8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6 UNKNOWN
* 22fb6052ee84211a79a360d04600c98697d80afa Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16710)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1526414671
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
}, {
"hash" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693",
"triggerID" : "1524476805",
"triggerType" : "MANUAL"
}, {
"hash" : "22fb6052ee84211a79a360d04600c98697d80afa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16710",
"triggerID" : "22fb6052ee84211a79a360d04600c98697d80afa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6 UNKNOWN
* 22fb6052ee84211a79a360d04600c98697d80afa Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16710)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1525159081
> @danny0405 integrated your patch. Now I need to:
>
> * confirm the test breaks without the change
> * assert not throw npe
Yeah, that makes sense, I run the 2 tests locally and they can pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1524488845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
}, {
"hash" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693",
"triggerID" : "1524476805",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3e9388ee9a6edaa6caab4f738b093f82744bc7dc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693)
* 8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1522728301
Thanks for the fix, I have reviewed and created a patch:
[6072.patch.zip](https://github.com/apache/hudi/files/11328753/6072.patch.zip)
You can rebase with the latest master, apply the patch and then force-push with the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1520887131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4502dad350e0dc84299dc0bd5889506420b0f49 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266)
* a59cd66283dafe08691023f579f4cadb6308d63f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1509606563
> Tests based on the spark datasource api (similar to the eg in the OP) or do you have a better idea?
Either data sorurce api or sql should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1521663805
> @danny0405 added stuff for tests, bug cannot setup intellij to debug/run tests locally (pain following the https://hudi.apache.org/contribute/developer-setup)
Could we fix line 191 instead, that could fix all the data type with null values, covering also the atomic data types.
You can also use the `mvn test` cmd for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1521655491
@danny0405 added stuff for tests, bug cannot setup intellij to debug/run tests locally (pain following the https://hudi.apache.org/contribute/developer-setup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8432:
URL: https://github.com/apache/hudi/pull/8432#discussion_r1176127485
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/HoodieInternalRowUtils.scala:
##########
@@ -224,29 +224,32 @@ object HoodieInternalRowUtils {
fieldNameStack.pop()
(fieldUpdater, ordinal, value) => {
- val prevArrayData = value.asInstanceOf[ArrayData]
- val prevArray = prevArrayData.toObjectArray(prevElementType)
-
- val newArrayData = createArrayData(newElementType, prevArrayData.numElements())
- val elementUpdater = new ArrayDataUpdater(newArrayData)
-
- var i = 0
- while (i < prevArray.length) {
- val element = prevArray(i)
- if (element == null) {
- if (!containsNull) {
- throw new HoodieException(
- s"Array value at path '${fieldNameStack.asScala.mkString(".")}' is not allowed to be null")
+ if (value == null) {
+ fieldUpdater.setNullAt(ordinal)
+ } else {
+ val prevArrayData = value.asInstanceOf[ArrayData]
+ val prevArray = prevArrayData.toObjectArray(prevElementType)
+
Review Comment:
Could we fix line 191 instead, that could fix all the data type with null values, covering also the atomic data types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1526938835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
}, {
"hash" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693",
"triggerID" : "1524476805",
"triggerType" : "MANUAL"
}, {
"hash" : "22fb6052ee84211a79a360d04600c98697d80afa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16710",
"triggerID" : "22fb6052ee84211a79a360d04600c98697d80afa",
"triggerType" : "PUSH"
}, {
"hash" : "2e3f72f1a66e7108fbb1167dfde17c248639638c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e3f72f1a66e7108fbb1167dfde17c248639638c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6 UNKNOWN
* 22fb6052ee84211a79a360d04600c98697d80afa Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16710)
* 2e3f72f1a66e7108fbb1167dfde17c248639638c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1520908766
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4502dad350e0dc84299dc0bd5889506420b0f49 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266)
* a59cd66283dafe08691023f579f4cadb6308d63f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1525833564
@danny0405 added a commit to apply the exact same context as the issue. The previous tests did not fail w/o the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1525111734
@danny0405 integrated your patch. Now I need to:
- confirm the test breaks without the change
- assert not throw npe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1522084930
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a59cd66283dafe08691023f579f4cadb6308d63f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622)
* 3e9388ee9a6edaa6caab4f738b093f82744bc7dc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1522508319
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e9388ee9a6edaa6caab4f738b093f82744bc7dc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1506506559
Tests based on the spark datasource api (similar to the eg in the OP) or do you have a better idea?
On April 13, 2023 6:35:17 AM UTC, Danny Chan ***@***.***> wrote:
>@danny0405 commented on this pull request.
>
>
>
>> - val newArrayData = createArrayData(newElementType, prevArrayData.numElements())
>- val elementUpdater = new ArrayDataUpdater(newArrayData)
>-
>- var i = 0
>- while (i < prevArray.length) {
>- val element = prevArray(i)
>- if (element == null) {
>- if (!containsNull) {
>- throw new HoodieException(
>- s"Array value at path '${fieldNameStack.asScala.mkString(".")}' is not allowed to be null")
>+ if (value == null) {
>+ fieldUpdater.setNullAt(ordinal)
>+ } else {
>+ val prevArrayData = value.asInstanceOf[ArrayData]
>+ val prevArray = prevArrayData.toObjectArray(prevElementType)
>+
>
>Thanks for the contribution, can we add some test cases?
>
>--
>Reply to this email directly or view it on GitHub:
>https://github.com/apache/hudi/pull/8432#pullrequestreview-1382731324
>You are receiving this because you authored the thread.
>
>Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1524841754
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
}, {
"hash" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693",
"triggerID" : "1524476805",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3e9388ee9a6edaa6caab4f738b093f82744bc7dc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693)
* 8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1504104875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4502dad350e0dc84299dc0bd5889506420b0f49 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8432: Fix NPE when upsert merger and null map or array
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8432:
URL: https://github.com/apache/hudi/pull/8432#discussion_r1165066350
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/HoodieInternalRowUtils.scala:
##########
@@ -224,29 +224,32 @@ object HoodieInternalRowUtils {
fieldNameStack.pop()
(fieldUpdater, ordinal, value) => {
- val prevArrayData = value.asInstanceOf[ArrayData]
- val prevArray = prevArrayData.toObjectArray(prevElementType)
-
- val newArrayData = createArrayData(newElementType, prevArrayData.numElements())
- val elementUpdater = new ArrayDataUpdater(newArrayData)
-
- var i = 0
- while (i < prevArray.length) {
- val element = prevArray(i)
- if (element == null) {
- if (!containsNull) {
- throw new HoodieException(
- s"Array value at path '${fieldNameStack.asScala.mkString(".")}' is not allowed to be null")
+ if (value == null) {
+ fieldUpdater.setNullAt(ordinal)
+ } else {
+ val prevArrayData = value.asInstanceOf[ArrayData]
+ val prevArray = prevArrayData.toObjectArray(prevElementType)
+
Review Comment:
Thanks for the contribution, can we add some test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1504056666
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4502dad350e0dc84299dc0bd5889506420b0f49 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on a diff in pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on code in PR #8432:
URL: https://github.com/apache/hudi/pull/8432#discussion_r1176737272
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/HoodieInternalRowUtils.scala:
##########
@@ -224,29 +224,32 @@ object HoodieInternalRowUtils {
fieldNameStack.pop()
(fieldUpdater, ordinal, value) => {
- val prevArrayData = value.asInstanceOf[ArrayData]
- val prevArray = prevArrayData.toObjectArray(prevElementType)
-
- val newArrayData = createArrayData(newElementType, prevArrayData.numElements())
- val elementUpdater = new ArrayDataUpdater(newArrayData)
-
- var i = 0
- while (i < prevArray.length) {
- val element = prevArray(i)
- if (element == null) {
- if (!containsNull) {
- throw new HoodieException(
- s"Array value at path '${fieldNameStack.asScala.mkString(".")}' is not allowed to be null")
+ if (value == null) {
+ fieldUpdater.setNullAt(ordinal)
+ } else {
+ val prevArrayData = value.asInstanceOf[ArrayData]
+ val prevArray = prevArrayData.toObjectArray(prevElementType)
+
Review Comment:
thanks, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1522095630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a59cd66283dafe08691023f579f4cadb6308d63f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622)
* 3e9388ee9a6edaa6caab4f738b093f82744bc7dc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1526943724
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
}, {
"hash" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693",
"triggerID" : "1524476805",
"triggerType" : "MANUAL"
}, {
"hash" : "22fb6052ee84211a79a360d04600c98697d80afa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16710",
"triggerID" : "22fb6052ee84211a79a360d04600c98697d80afa",
"triggerType" : "PUSH"
}, {
"hash" : "2e3f72f1a66e7108fbb1167dfde17c248639638c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16720",
"triggerID" : "2e3f72f1a66e7108fbb1167dfde17c248639638c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6 UNKNOWN
* 22fb6052ee84211a79a360d04600c98697d80afa Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16710)
* 2e3f72f1a66e7108fbb1167dfde17c248639638c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16720)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8432:
URL: https://github.com/apache/hudi/pull/8432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1525905963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
}, {
"hash" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693",
"triggerID" : "1524476805",
"triggerType" : "MANUAL"
}, {
"hash" : "22fb6052ee84211a79a360d04600c98697d80afa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "22fb6052ee84211a79a360d04600c98697d80afa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e9388ee9a6edaa6caab4f738b093f82744bc7dc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16693)
* 8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6 UNKNOWN
* 22fb6052ee84211a79a360d04600c98697d80afa UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8432: [HUDI-6072] Fix NPE when upsert merger and null map or array
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1523623222
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16266",
"triggerID" : "f4502dad350e0dc84299dc0bd5889506420b0f49",
"triggerType" : "PUSH"
}, {
"hash" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16622",
"triggerID" : "a59cd66283dafe08691023f579f4cadb6308d63f",
"triggerType" : "PUSH"
}, {
"hash" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650",
"triggerID" : "3e9388ee9a6edaa6caab4f738b093f82744bc7dc",
"triggerType" : "PUSH"
}, {
"hash" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e9388ee9a6edaa6caab4f738b093f82744bc7dc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16650)
* 8a67f296a325ef968f5a29ac5cd0c75a0f7c83c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org