[GitHub] [poi] kiwiwings commented on pull request #198: Remove jdk.charset module dependency for spreadsheets generation

[GitBox <gi...@apache.org>]

kiwiwings commented on pull request #198:
URL: https://github.com/apache/poi/pull/198#issuecomment-731607535


   > The build failure looks unrelated to my changes
   > 
   > ```
   > /home/travis/build/apache/poi/build.xml:938: javac doesn't support the "release" attribute
   > ```
   
   If you get that warning, your javac is not running in Java 9+ mode. I thought I've changed the build in a way, that it recognizes the JVM. So it uses classpath mode for Java 8 and modulepath mode for Java 9+. if this doesn't work for your environment, I need to investigate what's the difference there ... with your help.
   
   anyway with this warning and your proposed change, I think the tests are running in classpath mode and therefore aren't significant ...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org