You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2017/03/16 02:06:13 UTC
[GitHub] zeppelin pull request #2142: [ZEPPELIN-2124] Missing dependencies array in i...
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/2142
[ZEPPELIN-2124] Missing dependencies array in interpreter.json after upgrade from 0.6.2 to 0.7.0
### What is this PR for?
If there is no `dependencies` field specified in `interpreter.json`, front-end throws error because it tries to push new element to undefined variable. This PR fixes this issue by setting initial value of `dependencies` to empty array.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-2124](https://issues.apache.org/jira/browse/ZEPPELIN-2124)
### How should this be tested?
Remove `dependencies` field from `conf/interpreter.json` and try to add new dependencies in http://localhost:8080/#/interpreter page.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-2124
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2142
----
commit 01b27ebd78203f4befcc88a555671864c5d8d3f4
Author: Mina Lee <mi...@apache.org>
Date: 2017-03-16T01:57:38Z
Assign init value for dependencies field
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2142: [ZEPPELIN-2124] Missing dependencies array in i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2142: [ZEPPELIN-2124] Missing dependencies array in i...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee closed the pull request at:
https://github.com/apache/zeppelin/pull/2142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2142: [ZEPPELIN-2124] Missing dependencies array in i...
Posted by minahlee <gi...@git.apache.org>.
GitHub user minahlee reopened a pull request:
https://github.com/apache/zeppelin/pull/2142
[ZEPPELIN-2124] Missing dependencies array in interpreter.json after upgrade from 0.6.2 to 0.7.0
### What is this PR for?
If there is no `dependencies` field specified in `interpreter.json`, front-end throws error because it tries to push new element to undefined variable. This PR fixes this issue by setting initial value of `dependencies` to empty array.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-2124](https://issues.apache.org/jira/browse/ZEPPELIN-2124)
### How should this be tested?
Remove `dependencies` field from `conf/interpreter.json` and try to add new dependencies in http://localhost:8080/#/interpreter page.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-2124
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2142
----
commit 01b27ebd78203f4befcc88a555671864c5d8d3f4
Author: Mina Lee <mi...@apache.org>
Date: 2017-03-16T01:57:38Z
Assign init value for dependencies field
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2142: [ZEPPELIN-2124] Missing dependencies array in interpre...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2142
That's very simple :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---