You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Issac Goldstand <ma...@beamartyr.net> on 2007/11/14 15:06:51 UTC
[PROPOSAL] Adoption of mod_dns to httpd?
I'd like to offer up mod_dns
(http://www.beamartyr.net/mod-dns-1.02.tar.bz2) for inclusion in the
httpd project (either as a mod_ftp-like subproject, or as module with
the standard distribution - whatever people prefer). Can people vote
for what they're most comfortable with?
[ ] Immediate adoption as an included module (pending IP clearance via
the incubator)
[ ] Immediate adoption as a subproject (pending IP clearance via the
incubator)
[ ] Podling status in the incubator, followed by appropriate adoption at
graduation
[ ] No adoption by the ASF
Thanks,
Issac
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Sander Temme <sc...@apache.org>.
On Nov 14, 2007, at 9:17 AM, Justin Erenkrantz wrote:
>> [X] Immediate adoption as a subproject (pending IP clearance via the
>> incubator)
> - But, no separate mailing lists and no separate committers
+1
S.
--
Sander Temme
sctemme@apache.org
PGP FP: 51B4 8727 466A 0BC3 69F4 B7B8 B2BE BC40 1529 24AF
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Nov 14, 2007, at 9:17 AM, Justin Erenkrantz wrote:
> On Nov 14, 2007 9:06 AM, Issac Goldstand <ma...@beamartyr.net> wrote:
>> [ ] Immediate adoption as an included module (pending IP clearance
>> via
>> the incubator)
>> [X] Immediate adoption as a subproject (pending IP clearance via the
>> incubator)
> - But, no separate mailing lists and no separate committers
>
> It would live in: http://svn.apache.org/repos/asf/httpd/mod_dns/
>
> All discussion would be on dev@httpd, the httpd committers would all
> have commit to it, etc.
>
That's my expectation as well...
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Justin Erenkrantz wrote:
> On Nov 14, 2007 9:06 AM, Issac Goldstand <ma...@beamartyr.net> wrote:
>> [ ] Immediate adoption as an included module (pending IP clearance via
>> the incubator)
>> [X] Immediate adoption as a subproject (pending IP clearance via the
>> incubator)
> - But, no separate mailing lists and no separate committers
>
> It would live in: http://svn.apache.org/repos/asf/httpd/mod_dns/
>
> All discussion would be on dev@httpd, the httpd committers would all
> have commit to it, etc.
+1 - I can't imagine the bandwidth of discussions would tax 'pure http'ers'
patience, and sharing info on implementing alternate protocols is key.
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Plüm,
Rüdiger,
VF-Group <ru...@vodafone.com>.
> -----Ursprüngliche Nachricht-----
> Von:
> Im Auftrag von Justin Erenkrantz
> Gesendet: Mittwoch, 14. November 2007 15:18
> An: dev@httpd.apache.org
> Betreff: Re: [PROPOSAL] Adoption of mod_dns to httpd?
>
>
> On Nov 14, 2007 9:06 AM, Issac Goldstand <ma...@beamartyr.net> wrote:
> > [ ] Immediate adoption as an included module (pending IP
> clearance via
> > the incubator)
> > [X] Immediate adoption as a subproject (pending IP clearance via the
> > incubator)
> - But, no separate mailing lists and no separate committers
>
> It would live in: http://svn.apache.org/repos/asf/httpd/mod_dns/
>
> All discussion would be on dev@httpd, the httpd committers would all
> have commit to it, etc.
+1 to this option.
Regards
Rüdiger
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Nov 14, 2007 9:06 AM, Issac Goldstand <ma...@beamartyr.net> wrote:
> [ ] Immediate adoption as an included module (pending IP clearance via
> the incubator)
> [X] Immediate adoption as a subproject (pending IP clearance via the
> incubator)
- But, no separate mailing lists and no separate committers
It would live in: http://svn.apache.org/repos/asf/httpd/mod_dns/
All discussion would be on dev@httpd, the httpd committers would all
have commit to it, etc.
Thanks. -- justin
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Guenter Knauf <fu...@apache.org>.
Hi Issac,
Issac Goldstand schrieb:
> I don't think that #include "rr.h" would work with apxs (which is the
> build method that I wrote it around).
no problem; you can just tell apxs to use an include path; I've just tried on my SuSE box with:
apxs2 -c -I . *.c rr/*.c > build.log 2>&1
here's the buildlog of the unpatched version:
http://www.gknw.net/test/mod_dns/build.log
and here after applying my _new_ patch (since gcc found some more things I did fix these too, and created a new diff; now only the implicit warning remains):
http://www.gknw.net/test/mod_dns/build_patched.log
and here the patched sources:
http://www.gknw.net/test/mod_dns/mod_dns-1.02.tar.gz
> For the type stuff, I'll look at it real soon. Meanwhile, did your
> patch solve the following?
> rr/rr.c: In function 'dns_rr_unserialize':
> rr/rr.c:194: warning: passing argument 3 of 'rrr->rdata->unserialize'
> from incompatible pointer type
yes, there was a void* cast needed.
> I'm not sure how well NetWare's going to be supported unless someone
> helps write apr_sendtov for NetWare (the only implementation that I
> couldn't figure out how to write); without it, you'll have TCP support only.
what was the problem? I can tell you that NetWare supports both Winsock2 and BSD sockets;
we use by default most of the Win32 socket stuff, but can switch over to using Unix socket stuff (with separate builds, not within one build).
Guenter.
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Issac Goldstand <ma...@beamartyr.net>.
Guenter Knauf wrote:
> Hi Issac,
>
>
>> I'd like to offer up mod_dns
>> (http://www.beamartyr.net/mod-dns-1.02.tar.bz2) for inclusion in the
>> httpd project (either as a mod_ftp-like subproject, or as module with
>> the standard distribution - whatever people prefer). Can people vote
>> for what they're most comfortable with?
>>
>
> [x ] Immediate adoption as a subproject (pending IP clearance via the incubator)
>
> I've just tried to compile the mod for NetWare, but my picky compiler wasnt fine with some type mismatches, mostly signed<->unsigned; here's a diff which shows what I needed to get it compiled:
> http://www.gknw.net/test/mod_dns/
> please check. I would also prefer to compile with vpath, and therefore the '../rr.h' include is a but ugly;
> would be nice if you agree to change this to just 'rr.h'.
> Also would be more nice if you rename the folder to use an underscore as usual, and use a version number like 1.0.2.
>
> Guenter.
>
Guenter,
I don't think that #include "rr.h" would work with apxs (which is the
build method that I wrote it around).
For the type stuff, I'll look at it real soon. Meanwhile, did your
patch solve the following?
rr/rr.c: In function 'dns_rr_unserialize':
rr/rr.c:194: warning: passing argument 3 of 'rrr->rdata->unserialize'
from incompatible pointer type
I'm not sure how well NetWare's going to be supported unless someone
helps write apr_sendtov for NetWare (the only implementation that I
couldn't figure out how to write); without it, you'll have TCP support only.
Issac
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Guenter Knauf <fu...@apache.org>.
Hi Issac,
> I'd like to offer up mod_dns
> (http://www.beamartyr.net/mod-dns-1.02.tar.bz2) for inclusion in the
> httpd project (either as a mod_ftp-like subproject, or as module with
> the standard distribution - whatever people prefer). Can people vote
> for what they're most comfortable with?
[x ] Immediate adoption as a subproject (pending IP clearance via the incubator)
I've just tried to compile the mod for NetWare, but my picky compiler wasnt fine with some type mismatches, mostly signed<->unsigned; here's a diff which shows what I needed to get it compiled:
http://www.gknw.net/test/mod_dns/
please check. I would also prefer to compile with vpath, and therefore the '../rr.h' include is a but ugly;
would be nice if you agree to change this to just 'rr.h'.
Also would be more nice if you rename the folder to use an underscore as usual, and use a version number like 1.0.2.
Guenter.
[PATCH] fix for const mismatch in 2.0.x ssl_scache_shmht.c
Posted by Guenter Knauf <fu...@apache.org>.
Hi all,
when I try to compile Apache 2.0.x mod_ssl with OpenSSL 0.9.8 then I get a const mismatch:
### mwccnlm Compiler:
# File: ssl_scache_shmht.c
# ---------------------------
# 237: sess = d2i_SSL_SESSION(NULL, &ucpData, nData);
# Error: ^
# illegal implicit conversion from 'unsigned char **' to
# 'const unsigned char **'
Errors caused tool to abort.
since this file is not present in 2.2.x branch and later the problem
doesnt happen there, and so I cant propose a backport here ...
here's the patch:
--- ssl_scache_shmht.c.orig Wed Jul 12 09:40:56 2006
+++ ssl_scache_shmht.c Sun Nov 25 17:01:26 2007
@@ -234,7 +234,8 @@
}
/* unstreamed SSL_SESSION */
- sess = d2i_SSL_SESSION(NULL, &ucpData, nData);
+ sess = d2i_SSL_SESSION(NULL,
+ (MODSSL_D2I_SSL_SESSION_CONST UCHAR **)&ucpData, nData);
return sess;
}
can I get some agreement to commit this patch?
I also thought of another patch changing ucpData as done in the other
ssl_scache_* files, however then another cast with memcpy() is needed;
therefore I tend more to the first patch:
--- ssl_scache_shmht.c.orig Wed Jul 12 09:40:56 2006
+++ ssl_scache_shmht.c Sun Nov 25 17:32:58 2007
@@ -198,7 +198,7 @@
SSLModConfigRec *mc = myModConfig(s);
void *vp;
SSL_SESSION *sess = NULL;
- UCHAR *ucpData;
+ MODSSL_D2I_SSL_SESSION_CONST UCHAR *ucpData;
int nData;
time_t expiry;
time_t now;
@@ -223,7 +223,7 @@
return NULL;
}
memcpy(&expiry, vp, sizeof(time_t));
- memcpy(ucpData, (char *)vp+sizeof(time_t), nData);
+ memcpy((void *)ucpData, (char *)vp+sizeof(time_t), nData);
ssl_mutex_off(s);
/* make sure the stuff is still not expired */
thanks, Guenter.
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Jorge Schrauwen <jo...@gmail.com>.
On Nov 14, 2007 3:06 PM, Issac Goldstand <ma...@beamartyr.net> wrote:
> I'd like to offer up mod_dns
> (http://www.beamartyr.net/mod-dns-1.02.tar.bz2) for inclusion in the
> httpd project (either as a mod_ftp-like subproject, or as module with
> the standard distribution - whatever people prefer). Can people vote
> for what they're most comfortable with?
>
> [ ] Immediate adoption as an included module (pending IP clearance via
> the incubator)
> [ X ] Immediate adoption as a subproject (pending IP clearance via the
> incubator)
> [ ] Podling status in the incubator, followed by appropriate adoption at
> graduation
> [ ] No adoption by the ASF
>
> Thanks,
> Issac
>
>
>
As a subproject would make more sense.
Since this project is still called httpd and not d or ftpd or dnsd :)
--
~Jorge
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Nov 14, 2007, at 9:06 AM, Issac Goldstand wrote:
> I'd like to offer up mod_dns
> (http://www.beamartyr.net/mod-dns-1.02.tar.bz2) for inclusion in the
> httpd project (either as a mod_ftp-like subproject, or as module with
> the standard distribution - whatever people prefer). Can people vote
> for what they're most comfortable with?
>
> [ ] Immediate adoption as an included module (pending IP clearance via
> the incubator)
> [X] Immediate adoption as a subproject (pending IP clearance via the
> incubator)
> [ ] Podling status in the incubator, followed by appropriate
> adoption at
> graduation
> [ ] No adoption by the ASF
>
Cool stuff...
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Issac Goldstand <ma...@beamartyr.net>.
Nick Kew wrote:
> On Wed, 14 Nov 2007 09:06:51 -0500
> Issac Goldstand <ma...@beamartyr.net> wrote:
>
>
>> I'd like to offer up mod_dns
>> (http://www.beamartyr.net/mod-dns-1.02.tar.bz2) for inclusion in the
>> httpd project (either as a mod_ftp-like subproject, or as module with
>> the standard distribution - whatever people prefer). Can people vote
>> for what they're most comfortable with?
>>
>> [ ] Immediate adoption as an included module (pending IP clearance via
>> the incubator)
>> [ ] Immediate adoption as a subproject (pending IP clearance via the
>> incubator)
>> [ ] Podling status in the incubator, followed by appropriate adoption
>> at graduation
>> [ ] No adoption by the ASF
>>
>
> What's the current status? How many developers, users?
> Any libraries or other dependencies required, beyond those
> used by the standard httpd? Any user docs?
>
>
Developers: me, but I'm willing to go over it with anyone in Atlanta to
help get people up to speed. We're looking at it a bit to help plan the
UDP buckets, anyway...
Users: internally in our company (we just released it under AL this
week, though it was only the plan)
Dependencies: none (except apr(-util))
Docs: patches welcome :-D Seriously, as part of adoption we should play
quick catch-up, which I'd be happy to do. Mostly needed for API, users
have less directives (so far) than you can count on one hand
Issac
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Nick Kew <ni...@webthing.com>.
On Wed, 14 Nov 2007 09:06:51 -0500
Issac Goldstand <ma...@beamartyr.net> wrote:
> I'd like to offer up mod_dns
> (http://www.beamartyr.net/mod-dns-1.02.tar.bz2) for inclusion in the
> httpd project (either as a mod_ftp-like subproject, or as module with
> the standard distribution - whatever people prefer). Can people vote
> for what they're most comfortable with?
>
> [ ] Immediate adoption as an included module (pending IP clearance via
> the incubator)
> [ ] Immediate adoption as a subproject (pending IP clearance via the
> incubator)
> [ ] Podling status in the incubator, followed by appropriate adoption
> at graduation
> [ ] No adoption by the ASF
What's the current status? How many developers, users?
Any libraries or other dependencies required, beyond those
used by the standard httpd? Any user docs?
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
Re: [PROPOSAL] Adoption of mod_dns to httpd?
Posted by Paul Querna <ch...@force-elite.com>.
Issac Goldstand wrote:
> [ ] Immediate adoption as an included module (pending IP clearance via
> the incubator)
> [x] Immediate adoption as a subproject (pending IP clearance via the
> incubator)
> [ ] Podling status in the incubator, followed by appropriate adoption at
> graduation
> [ ] No adoption by the ASF
-Paul