You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Jongyoul Lee <jo...@gmail.com> on 2015/11/27 08:59:53 UTC
[DISCUSS]Strict code style and PR guide
Hi devs,
I think It's time to make codes clean and clear. In the former stage of
Zeppelin, It's important to add functions to enrich codes but, as time
goes, with several codes style, it's hard to maintain code quality. I
suggest it's good to follow Flink's way(
http://flink.apache.org/contribute-code.html) which looks a little bit
strict but that results in a clear code base.
Feel free to talk about it,
Best,
Jongyoul
--
이종열, Jongyoul Lee, 李宗烈
http://madeng.net
Re: [DISCUSS]Strict code style and PR guide
Posted by Konstantin Boudnik <co...@apache.org>.
Good points! There's another benefit to it: with a common set of coding styles
it'd easier to onboard new contributors. And it is easier for reviewers by
sticking to the same ground rules.
Cos
On Fri, Nov 27, 2015 at 10:48AM, Felix Cheung wrote:
> +1, +1 also on discussing Coding guideline / Coding style on
> http://flink.apache.org/contribute-code.html - think we should adopt it as
> applicable to this community.
>
> > From: moon@apache.org
> > Date: Fri, 27 Nov 2015 08:23:53 +0000
> > Subject: Re: [DISCUSS]Strict code style and PR guide
> > To: dev@zeppelin.incubator.apache.org
> >
> > So far, we have two related docs.
> >
> > http://zeppelin.incubator.apache.org/docs/latest/development/howtocontribute.html
> > https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md
> >
> > Having a code-contribution guide, such as Flink's one is going to help not
> > only code quality but also getting more code contribution.
> >
> > I completely agree on this idea and I think community can shape the detail
> > of the guide.
> >
> > I also suggest have one similar to
> > http://flink.apache.org/how-to-contribute.html, which is guide to overall
> > contribution.
> >
> > Thanks,
> > moon
> >
> > On Fri, Nov 27, 2015 at 5:00 PM Jongyoul Lee <jo...@gmail.com> wrote:
> >
> > > Hi devs,
> > >
> > > I think It's time to make codes clean and clear. In the former stage of
> > > Zeppelin, It's important to add functions to enrich codes but, as time
> > > goes, with several codes style, it's hard to maintain code quality. I
> > > suggest it's good to follow Flink's way(
> > > http://flink.apache.org/contribute-code.html) which looks a little bit
> > > strict but that results in a clear code base.
> > >
> > > Feel free to talk about it,
> > >
> > > Best,
> > > Jongyoul
> > >
> > > --
> > > ������, Jongyoul Lee, ����֭
> > > http://madeng.net
> > >
>
RE: [DISCUSS]Strict code style and PR guide
Posted by Felix Cheung <fe...@hotmail.com>.
+1, +1 also on discussing Coding guideline / Coding style on http://flink.apache.org/contribute-code.html - think we should adopt it as applicable to this community.
> From: moon@apache.org
> Date: Fri, 27 Nov 2015 08:23:53 +0000
> Subject: Re: [DISCUSS]Strict code style and PR guide
> To: dev@zeppelin.incubator.apache.org
>
> So far, we have two related docs.
>
> http://zeppelin.incubator.apache.org/docs/latest/development/howtocontribute.html
> https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md
>
> Having a code-contribution guide, such as Flink's one is going to help not
> only code quality but also getting more code contribution.
>
> I completely agree on this idea and I think community can shape the detail
> of the guide.
>
> I also suggest have one similar to
> http://flink.apache.org/how-to-contribute.html, which is guide to overall
> contribution.
>
> Thanks,
> moon
>
> On Fri, Nov 27, 2015 at 5:00 PM Jongyoul Lee <jo...@gmail.com> wrote:
>
> > Hi devs,
> >
> > I think It's time to make codes clean and clear. In the former stage of
> > Zeppelin, It's important to add functions to enrich codes but, as time
> > goes, with several codes style, it's hard to maintain code quality. I
> > suggest it's good to follow Flink's way(
> > http://flink.apache.org/contribute-code.html) which looks a little bit
> > strict but that results in a clear code base.
> >
> > Feel free to talk about it,
> >
> > Best,
> > Jongyoul
> >
> > --
> > 이종열, Jongyoul Lee, 李宗烈
> > http://madeng.net
> >
Re: [DISCUSS]Strict code style and PR guide
Posted by moon soo Lee <mo...@apache.org>.
So far, we have two related docs.
http://zeppelin.incubator.apache.org/docs/latest/development/howtocontribute.html
https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md
Having a code-contribution guide, such as Flink's one is going to help not
only code quality but also getting more code contribution.
I completely agree on this idea and I think community can shape the detail
of the guide.
I also suggest have one similar to
http://flink.apache.org/how-to-contribute.html, which is guide to overall
contribution.
Thanks,
moon
On Fri, Nov 27, 2015 at 5:00 PM Jongyoul Lee <jo...@gmail.com> wrote:
> Hi devs,
>
> I think It's time to make codes clean and clear. In the former stage of
> Zeppelin, It's important to add functions to enrich codes but, as time
> goes, with several codes style, it's hard to maintain code quality. I
> suggest it's good to follow Flink's way(
> http://flink.apache.org/contribute-code.html) which looks a little bit
> strict but that results in a clear code base.
>
> Feel free to talk about it,
>
> Best,
> Jongyoul
>
> --
> 이종열, Jongyoul Lee, 李宗烈
> http://madeng.net
>