[jira] Commented: (LUCENENET-172) This patch fixes the unexceptional exceptions ecountered in FastCharStream and SupportClass

["George Aroush (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENENET-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678694#action_12678694 ] 

George Aroush commented on LUCENENET-172:
-----------------------------------------

Hi Ben,

Applying this patch will immediately break the existing demos that come with Lucene, as well as the demos in book "Lucene in Action".  In addition, anyone who is using those two public functions, their code will break if this patch is applied.

I'm good with your suggestion that the patch be available for anyone who wants it, but not committing it to the trunks.

I would suggest that you submit a JIRA issue against Java Lucene, and request that they fix it (and offer a patch, preferably in Java, if you can).  They can do so by depreciating the current two functions and adding two new once.

Regards,

-- George

> This patch fixes the unexceptional exceptions ecountered in FastCharStream and SupportClass
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENENET-172
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-172
>             Project: Lucene.Net
>          Issue Type: Improvement
>            Reporter: Ben Martz
>         Attachments: lucene_2.3.1_exceptions_fix.patch
>
>
> The java version of Lucene handles end-of-file in FastCharStream by throwing an exception. This behavior has been ported to .NET but the behavior carries an unacceptable cost in the .NET environment. This patch is based on the prior work in LUCENENET-8 and LUCENENET-11, which I gratefully acknowledge for the solution. While I understand that this patch is outside of the current project specification in that it deviates from the "pure" nature of the port, I believe that it is very important to make the patch available to any developer looking to leverage Lucene.Net in their project. Thanks for your consideration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.