You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/18 07:58:59 UTC
[GitHub] [pulsar] sijie opened a new pull request #9228: Handle web application exception to redirect request
sijie opened a new pull request #9228:
URL: https://github.com/apache/pulsar/pull/9228
*Motivation*
`validateNamespaceBundleOwnership` throws a web application exception with `Response.temporaryRedirect(redirect)`
to redirect the request to the owner broker. But the web application exception is a runtime exception. If you don't
handle and propagate it correctly, it will cause web request to be hang.
PR #8746 changed some web calls to async but it doesn't handle the web application exception. It causes `topics list`
with non-persistent topics to be hang.
This pull request make sure the callers of `validateNamespaceBundleOwnership` catch and propagate the exceptions to
web response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #9228: Handle web application exception to redirect request
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9228:
URL: https://github.com/apache/pulsar/pull/9228#issuecomment-762538032
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9228: Handle web application exception to redirect request
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9228:
URL: https://github.com/apache/pulsar/pull/9228#issuecomment-762506021
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #9228: Handle web application exception to redirect request
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9228:
URL: https://github.com/apache/pulsar/pull/9228#issuecomment-762266806
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #9228: Handle web application exception to redirect request
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9228:
URL: https://github.com/apache/pulsar/pull/9228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9228: Handle web application exception to redirect request
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9228:
URL: https://github.com/apache/pulsar/pull/9228#issuecomment-762553504
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9228: Handle web application exception to redirect request
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9228:
URL: https://github.com/apache/pulsar/pull/9228#issuecomment-762300572
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org