[GitHub] [ignite] ivandasch commented on a diff in pull request #10729: IGNITE-15629 Consistency command implemented

["ivandasch (via GitHub)" <gi...@apache.org>]

ivandasch commented on code in PR #10729:
URL: https://github.com/apache/ignite/pull/10729#discussion_r1201967899


##########
modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerConsistencyTest.java:
##########
@@ -297,9 +296,9 @@ public void testRepairNonExistentCache() throws Exception {
         for (int i = 0; i < PARTITIONS; i++) {
             assertEquals(EXIT_CODE_UNEXPECTED_ERROR,
                 execute("--consistency", "repair",
-                    ConsistencyCommand.CACHE, "non-existent",
-                    ConsistencyCommand.PARTITIONS, String.valueOf(i),
-                    ConsistencyCommand.STRATEGY, strategy.toString()));
+                    KillCommandsControlShTest.CACHE, "non-existent",

Review Comment:
   I suppose it would be more clear if you define these constants in this test class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org