You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/06/23 18:55:43 UTC

Review Request 35788: Download Client Configs function results in an exception and error 500

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35788/
-----------------------------------------------------------

Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-11827
    https://issues.apache.org/jira/browse/AMBARI-11827


Repository: ambari


Description
-------

when download client config is clicked, it fails with script not found error.
It is getting wrong path of the script (noice 'stacks' is twice in path). All other commands (start,stop,restart, capture work well.)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java c42814f 

Diff: https://reviews.apache.org/r/35788/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 35788: Download Client Configs function results in an exception and error 500

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35788/#review89199
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On June 24, 2015, 5:43 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35788/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 5:43 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-11827
>     https://issues.apache.org/jira/browse/AMBARI-11827
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> when download client config is clicked, it fails with script not found error.
> It is getting wrong path of the script (noice 'stacks' is twice in path). All other commands (start,stop,restart, capture work well.)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java c42814f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 9d78245 
> 
> Diff: https://reviews.apache.org/r/35788/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 35788: Download Client Configs function results in an exception and error 500

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35788/
-----------------------------------------------------------

(Updated Червень 24, 2015, 5:43 після полудня)


Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-11827
    https://issues.apache.org/jira/browse/AMBARI-11827


Repository: ambari


Description
-------

when download client config is clicked, it fails with script not found error.
It is getting wrong path of the script (noice 'stacks' is twice in path). All other commands (start,stop,restart, capture work well.)


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java c42814f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 9d78245 

Diff: https://reviews.apache.org/r/35788/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 35788: Download Client Configs function results in an exception and error 500

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35788/#review88997
-----------------------------------------------------------


Was this tested with scenario when service package is not in common-services (which seems to be the bug)?

- Andrew Onischuk


On June 23, 2015, 4:55 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35788/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 4:55 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-11827
>     https://issues.apache.org/jira/browse/AMBARI-11827
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> when download client config is clicked, it fails with script not found error.
> It is getting wrong path of the script (noice 'stacks' is twice in path). All other commands (start,stop,restart, capture work well.)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java c42814f 
> 
> Diff: https://reviews.apache.org/r/35788/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>