[GitHub] [druid] ccaominh commented on a change in pull request #10449: Fix the offset setting in GoogleStorage#get

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #10449:
URL: https://github.com/apache/druid/pull/10449#discussion_r496904149



##########
File path: extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleTaskLogsTest.java
##########
@@ -134,19 +134,21 @@ public void testStreamTaskLogWithoutOffset() throws Exception
   public void testStreamTaskLogWithPositiveOffset() throws Exception
   {
     final String testLog = "hello this is a log";
+    final String expectedLog = testLog.substring(5);

Review comment:
       Since it appears in a couple places for this method, may be useful to have a named constant in this method for the value 5, similar to what was done in `testStreamTaskLogWithNegative()`.

##########
File path: pom.xml
##########
@@ -118,8 +118,9 @@
         <!-- When upgrading ZK, edit docs and integration tests as well (integration-tests/docker-base/setup.sh) -->
         <zookeeper.version>3.4.14</zookeeper.version>
         <checkerframework.version>2.5.7</checkerframework.version>
-        <com.google.apis.client.version>1.25.0</com.google.apis.client.version>
-        <com.google.apis.compute.version>v1-rev214-1.25.0</com.google.apis.compute.version>
+        <com.google.apis.client.version>1.26.0</com.google.apis.client.version>
+        <com.google.apis.compute.version>v1-rev20190607-1.26.0</com.google.apis.compute.version>
+        <com.google.apis.storage.version>v1-rev20190523-1.26.0</com.google.apis.storage.version>

Review comment:
       Similar to what was previously done in `extensions-core/google-extensions/pom.xml`, does it make sense to have the `1.26.0` suffix value provided by the `com.google.apis.client.version` property?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org