You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "waleedahmed0001 (via GitHub)" <gi...@apache.org> on 2023/01/28 17:04:30 UTC
[GitHub] [age] waleedahmed0001 opened a new pull request, #634: Added video links
waleedahmed0001 opened a new pull request, #634:
URL: https://github.com/apache/age/pull/634
I have added different video tutorials in it which will help in better understanding of Apache Age and people can easily understand using these videos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jbiz805 commented on pull request #634: Added video links
Posted by "jbiz805 (via GitHub)" <gi...@apache.org>.
jbiz805 commented on PR #634:
URL: https://github.com/apache/age/pull/634#issuecomment-1418538894
Check your spelling!
Once the spelling is fixed i think it's good to go imo, @jrgemignani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jbiz805 commented on pull request #634: Added video links
Posted by "jbiz805 (via GitHub)" <gi...@apache.org>.
jbiz805 commented on PR #634:
URL: https://github.com/apache/age/pull/634#issuecomment-1411245113
Hi waleedahmed0001, thanks for taking the time in contributing to the readme file!
Any new additions in the readme are welcome, as long as it is kept within the format.
I've got some comments to share regarding the addition you made so please consider refining it and request again.
**1) Icon**
- Include an icon that represents Video Links (refer to other titles)
**2) Specify which OS**
- Specify which installation it's for. The link provided is Windows (made by one of the interns)
- also add MacOS edition
- name the link differently. For Example, "Install on Windows" (enter+new bullet point) "Install on MacOS"
**3) Outdated**
- This link is a webinar on AGE during the incubating stage. The details are outdated. Remove.
**4) For Internal use only**
- This video is only shared with AGE internal personnel. It should not be open to public.
**Final comment:**
Though having a video to explain AGE is a splendid idea, this is a readme.
Take into consideration if visitors will watch long webinar videos.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani merged pull request #634: Added video links
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani merged PR #634:
URL: https://github.com/apache/age/pull/634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #634: Added video links
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #634:
URL: https://github.com/apache/age/pull/634#issuecomment-1419553553
@waleedahmed0001 Please -
- Squash your Github comments to what is necessary.
- Use the present tense for the commit description.
After that, it looks good. @jbiz805?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] waleedahmed0001 commented on pull request #634: Added video links
Posted by "waleedahmed0001 (via GitHub)" <gi...@apache.org>.
waleedahmed0001 commented on PR #634:
URL: https://github.com/apache/age/pull/634#issuecomment-1411602769
> Hi waleedahmed0001, thanks for taking the time in contributing to the readme file! Any new additions in the readme are welcome, as long as it is kept within the format. I've got some comments to share regarding the addition you made so please consider refining it and request again.
>
> 
>
> **1) Icon**
>
> * Include an icon that represents Video Links (refer to other titles)
> **2) Specify which OS**
> * Specify which installation it's for. The link provided is Windows (made by one of the interns)
> * also add MacOS edition
> * name the link differently. For Example, "Install on Windows" (enter+new bullet point) "Install on MacOS"
> **3) Outdated**
> * This link is a webinar on AGE during the incubating stage. The details are outdated. Remove.
> **4) For Internal use only**
> * This video is only shared with AGE internal personnel. It should not be open to public.
>
> **Final comment:** Though having a video to explain AGE is a splendid idea, this is a readme. Take into consideration if visitors will watch long webinar videos.
>
> Thank you!
I will do these changes and then commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] waleedahmed0001 commented on pull request #634: Added video links
Posted by "waleedahmed0001 (via GitHub)" <gi...@apache.org>.
waleedahmed0001 commented on PR #634:
URL: https://github.com/apache/age/pull/634#issuecomment-1420341843
> > @waleedahmed0001 Please -
> >
> > * Squash your Github comments to what is necessary.
> > * Use the present tense for the commit description.
> >
> > After that, it looks good. @jbiz805?
>
> Just waiting on this.
I am done with those changes. You can review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jbiz805 commented on pull request #634: Added video links
Posted by "jbiz805 (via GitHub)" <gi...@apache.org>.
jbiz805 commented on PR #634:
URL: https://github.com/apache/age/pull/634#issuecomment-1419934689
looks good to me now @jrgemignani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #634: Added video links
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #634:
URL: https://github.com/apache/age/pull/634#issuecomment-1419948001
> @waleedahmed0001 Please -
>
> * Squash your Github comments to what is necessary.
> * Use the present tense for the commit description.
>
> After that, it looks good. @jbiz805?
Just waiting on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org