[GitHub] [iceberg] jackye1995 commented on a change in pull request #4280: [WIP] AWS: Add support for LakeFomration

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #4280:
URL: https://github.com/apache/iceberg/pull/4280#discussion_r821003829



##########
File path: api/src/main/java/org/apache/iceberg/Table.java
##########
@@ -286,4 +286,11 @@ default AppendFiles newFastAppend() {
    * Returns a {@link LocationProvider} to provide locations for new data files.
    */
   LocationProvider locationProvider();
+
+  /**
+   * Return a map of string parameters for this table.
+   *
+   * @return this table's parameters map
+   */
+  Map<String, String> parameters();

Review comment:
       Looks like the addition of `parameters` is for injecting the LF authorized column information. I think we can reduce the scope of this PR a little bit, to first offer only database and table level permission management. 
   
   I understand we cannot leverage `properties` because it will be written back in a commit if we add additional information. But adding another `parameters` is definitely confusing, and we should explore some better ways. It would be much clearer to discuss after we first add database and table level LF support with the existing Iceberg interfaces.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org