[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7880: Core: Add View support

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #7880:
URL: https://github.com/apache/iceberg/pull/7880#discussion_r1251101026


##########
api/src/main/java/org/apache/iceberg/view/ViewBuilder.java:
##########
@@ -111,6 +111,16 @@ public interface ViewBuilder {
    */
   ViewBuilder withProperty(String key, String value);
 
+  /**
+   * Add a view representation
+   *
+   * @param representation The view representation to add
+   * @return this for method chaining
+   */
+  default ViewBuilder withRepresentation(ViewRepresentation representation) {

Review Comment:
   +1 for B, I was asking about extending `ImmutableView.Builder` basically because I think we should directly expose the representation object in the builder, so plan B looks good to me. I hope there could be an easier way to express updating a representation instead of doing a remove and re-add, but it might be just unnecessarily complex, I am good with the current proposed `UpdateViewRepresentation` interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org