You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/06 19:25:26 UTC
[GitHub] [iceberg] szehon-ho opened a new pull request, #4976: Docs: Cleanup language in spec ORC type notes
szehon-ho opened a new pull request, #4976:
URL: https://github.com/apache/iceberg/pull/4976
Clean up some language in the user-facing spec documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4976: Format: Cleanup language in spec ORC type notes
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4976:
URL: https://github.com/apache/iceberg/pull/4976#issuecomment-1170240456
Thanks, @szehon-ho! Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on a diff in pull request #4976: Docs: Cleanup language in spec ORC type notes
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on code in PR #4976:
URL: https://github.com/apache/iceberg/pull/4976#discussion_r890477791
##########
format/spec.md:
##########
@@ -913,9 +913,9 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo
Notes:
-1. ORC's [TimestampColumnVector](https://orc.apache.org/api/hive-storage-api/org/apache/hadoop/hive/ql/exec/vector/TimestampColumnVector.html) comprises of a time field (milliseconds since epoch) and a nanos field (nanoseconds within the second). Hence the milliseconds within the second are reported twice; once in the time field and again in the nanos field. The read adapter should only use milliseconds within the second from one of these fields. The write adapter should also report milliseconds within the second twice; once in the time field and again in the nanos field. ORC writer is expected to correctly consider millis information from one of the fields. More details at https://issues.apache.org/jira/browse/ORC-546
Review Comment:
Explanation: "comprise of" is apparently not gramatically correct vs 'comprises' (from my editor's auto-correct which suggested to just use 'consists of' instead)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4976: Format: Cleanup language in spec ORC type notes
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4976:
URL: https://github.com/apache/iceberg/pull/4976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on a diff in pull request #4976: Docs: Cleanup language in spec ORC type notes
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on code in PR #4976:
URL: https://github.com/apache/iceberg/pull/4976#discussion_r890477791
##########
format/spec.md:
##########
@@ -913,9 +913,9 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo
Notes:
-1. ORC's [TimestampColumnVector](https://orc.apache.org/api/hive-storage-api/org/apache/hadoop/hive/ql/exec/vector/TimestampColumnVector.html) comprises of a time field (milliseconds since epoch) and a nanos field (nanoseconds within the second). Hence the milliseconds within the second are reported twice; once in the time field and again in the nanos field. The read adapter should only use milliseconds within the second from one of these fields. The write adapter should also report milliseconds within the second twice; once in the time field and again in the nanos field. ORC writer is expected to correctly consider millis information from one of the fields. More details at https://issues.apache.org/jira/browse/ORC-546
Review Comment:
Explanation: "comprise of" is apparently not gramatically correct, it's actually the other way : "a time field and nano field comprise ORC's TimestampColumnVector". This was from my editor's auto-correct which suggested to just use 'consists of' instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org