You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@perl.apache.org by Joe Orton <jo...@redhat.com> on 2009/10/21 13:48:55 UTC
Re: fixing an httpd test which is confused about which modules are
loaded in the test conf
On Fri, Oct 16, 2009 at 03:32:04PM -0400, Jeff Trawick wrote:
..
> --- Apache-Test/lib/Apache/TestConfigParse.pm (revision 822728)
> +++ Apache-Test/lib/Apache/TestConfigParse.pm (working copy)
> @@ -224,15 +224,15 @@
>
> $name = $modname_alias{$name} if $modname_alias{$name};
>
> - # remember all found modules
> - $self->{modules}->{$name} = $file;
> - debug "Found: $modname => $name";
> -
...
>
> So is either of these a reasonable fix? (It doesn't seem right that
> info.t has to worry about modules which were found in the
> configuration but not loaded, but I don't know what is expected of the
> configuration object.)
Either seems reasonable to me, though the use of the word "all" in the
original comment above might imply the placement of that code is
deliberate, so I'd probably go for the info.t patch.
Regards, Joe