You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/09 16:04:30 UTC
[GitHub] [airflow] leehuwuj opened a new pull request, #27573: add dag parsed time in DAG view
leehuwuj opened a new pull request, #27573:
URL: https://github.com/apache/airflow/pull/27573
At our company, user have to change their dag definition in their own git repository which is going to be pulled by git-sync service into our Airflow instance. Users have to wait a moment then checking the DAG code to see is their updates are refreshed in Airflow.
It'd be easier if we show the last parsed time in DAG view that user can easily compare the parsed time with current time.
This update will add a new label next to the `Next Run` tooltip of the DAG UI.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1309084542
Lets put it in the page body instead, above the code block? That work for you @bbovenzi?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] leehuwuj commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
leehuwuj commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1309116802
> Yeah, let's put it in `code.html` inbetween `subtitle` and `code`
I'm a bit confused, I think it's `dag_code.html` and it seems that the `code.html` has not be used for a long time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1309195491
> > Yeah, let's put it in `code.html` inbetween `subtitle` and `code`
>
> I'm a bit confused, I think it's `dag_code.html` and it seems that the `code.html` has not be used for a long time!
Yes, my bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1308986338
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1311945496
Thanks @leehuwuj! Congrats on your first commit 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #27573:
URL: https://github.com/apache/airflow/pull/27573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] leehuwuj commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
leehuwuj commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1311297637
Just moved to `dag_code.html`:
<img width="1288" alt="image" src="https://user-images.githubusercontent.com/39040748/201280742-d116bd35-3265-4f84-9b04-ffb178537234.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1309036563
Turns out it's already on the details page. What about if we added it to /code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] leehuwuj commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
leehuwuj commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1309082135
> Turns out it's already on the details page. What about if we added it to /code?
Good idea @jedcunningham , It'll be more friendly with users who checking their updates in the code without look closer into their code.
Should I keep the label there then add a condition to show in `/code` page only or put it inside the dag_code block?
I'll keep commit if our decision is simple because i'm not a front-end developer myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1309016087
Nice! I'm just not sure if that's the best place for that info. I think it may be better in the `/detail` page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1309094706
> Lets put it in the page body instead, above the code block? That work for you @bbovenzi?
Yeah, let's put it in `code.html` inbetween `subtitle` and `code`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #27573: add dag parsed time in DAG view
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #27573:
URL: https://github.com/apache/airflow/pull/27573#issuecomment-1311944796
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org